Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space between info.message and meta.message #1740

Merged
merged 2 commits into from
Jun 22, 2020

Conversation

rap2hpoutre
Copy link
Contributor

Fix #1739

@rap2hpoutre
Copy link
Contributor Author

appveyor fails but it seems normal

@jfirebaugh
Copy link

Also fixes #1634 and #1742 (this issue has been reported three times).

@valeriansaliou
Copy link

valeriansaliou commented Dec 12, 2019

Also experiencing this issue since migrating our code over from Winston 2 (while it was behaving fine, ie. with a space) to Winston 3. Only experiencing this when passing an Error instance as second argument.

Thanks for the fix, waiting for it to be merged :)

@JaanJah
Copy link

JaanJah commented Dec 27, 2019

Any info about when this is getting merged?

@jfirebaugh
Copy link

Anything we can do to help get this merged?

Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long hibernation -- this will go out in the next release. Thank you!

@DABH DABH merged commit 227ca0a into winstonjs:master Jun 22, 2020
@mbomfim33
Copy link

@DABH does this fixes #1634?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

info.message is concatenated with meta.message as is
6 participants