-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use safe stringify in http transport #2043
chore: use safe stringify in http transport #2043
Conversation
@karlwir I think we should use |
@DABH Agree, my mistake. PR updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me and this is consistent with the changes we made in logform
, so I'm okay with merging this. Thanks!
I love you @karlwir I needed this fix today 😆 |
Hi! Im getting
I'm using winston 3.6.0 and morgan 1.10.0 On Windows it works properly, but on linux breaks. |
Thanks for reporting that. The OS difference initially makes me wonder if there might be a filename reference with incorrect casing somewhere. |
It wasnt happening on winston@3.5.1, tho. |
It's definitely possible that the issue was newly introduced, and knowing that is quite helpful. I was just offering another signpost to possibly help with debugging as I don't have the time to do a full debug on it at the moment. |
Hello,
Issue:
#1946