-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Organize and restructure tests #2049
Chore: Organize and restructure tests #2049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I had a few questions and suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few finishing touches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not able to give this an in-depth review at this time, so I defer to those who can.
FWIW I'm okay with this once @fearphage gives the +1 :) |
This reverts commit 9b2fb38.
Summary
This PR is a subset of the changes I've made on the #1989 PR. This is primarily a reorganization effort of Winston's tests to further clarify their intent and make more obvious what is being tested by what. I'm pretty positive there are still
integration
tests in theunit
tests directory but it's at least moving things to be more explicit in nature.Tech Notes (pre-emptive comments left on git diff)
path.join
usage throughout all tests. These changes were necessary due to the directory level segregation of tests. While updating them I leveraged top-level constants to make them easier to update down the line.logger.test.ts
has been done. This was done to make the relationship between different tests more apparent.unit
tests.vows
depedency that is no longer present..nycrc
file for test's to retain a minimum level of coverage. This will help to ensure as new features are added the test coverage not continually degrade. I'd like to automate updating these values at some point but this is low priority.