Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add missing type definition of batch http option #2075

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Fix: add missing type definition of batch http option #2075

merged 1 commit into from
Feb 15, 2022

Conversation

KylinDC
Copy link
Contributor

@KylinDC KylinDC commented Feb 15, 2022

Hi, it looks like winston has support batch mode in HTTP Transport in recent release(#1970,

this.batch = options.batch || false;
), but in the type definition file, it still not support do the batch HTTP related configuration.
In this pull request, I add batch HTTP related types in transports type definition file to support configuration.

@wbt wbt merged commit d1d9358 into winstonjs:master Feb 15, 2022
@wbt
Copy link
Contributor

wbt commented Feb 15, 2022

Thanks @KylinDC!

@KylinDC
Copy link
Contributor Author

KylinDC commented Feb 16, 2022

My pleasure, thanks for bringing us such a wonderful library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants