Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update async to 3.2.3 #2112

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Update async to 3.2.3 #2112

merged 1 commit into from
Apr 28, 2022

Conversation

bacali95
Copy link

Since some of the other libraries still rely on the version 2 and it will take them some time to migrate, I open this PR to upgrade async from version 1 to 3 (yes huge difference but works the same) which at least will solve this Snyk vulnerability for winston 2.x.

@bacali95
Copy link
Author

Hello @indexzero, can you please take a look at this, thanks 🌷

@restfulhead
Copy link

Could you do a 2.x release with this upgrade please?

Copy link

@CesarOliveira CesarOliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bacali95
Copy link
Author

@CesarOliveira thanks for the approval, can you please merge it?

@CesarOliveira
Copy link

@CesarOliveira thanks for the approval, can you please merge it?

sorry, I don't have access to do it

@wbt wbt merged commit b17beca into winstonjs:2.x Apr 28, 2022
@wbt wbt added the Dependencies Pull requests that update a dependency file label Apr 28, 2022
@bacali95 bacali95 deleted the 2.x branch June 13, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants