Defensively cleanup streams #2231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
This is a nice workaround :) But since I think we wouldn't want something like this being the official way of doing things (it's obviously just a bandaid), I'm going to go ahead and close this PR. However, I'm absolutely going to keep it in mind as a reference while working on issues like #2100 (and what sounds like is going to be a new related issue, since #2301 seems to have solved the specific MWE of #2100). So this was not in vain -- but making a bit of effort to go through and clean up some old open PRs on winston. Thank you very much for your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix/workaround for #2100
This PR in local testing prevented file descriptors from leaking as demonstrated by running the
lsofcommand and not seeing file descriptors increase.The fix introduces a mechanism to capture all streams created in an array and ensures all are destroyed when
_cleanupStreamis called.The code reads to me like there should only ever be one file stream in scope at any time but for some reason we find multiple are created before they are closed.
This is a workaround really and it would be better to find the source of this issue; streams are being created but not cleaned up, this fix just ensures the resource leak does not occur.