Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly allow passing non-arry transport #2256

Merged
merged 3 commits into from
Jan 2, 2023
Merged

Conversation

Tanuel
Copy link
Contributor

@Tanuel Tanuel commented Dec 14, 2022

LoggerOptions allows transports to be a single Transport instance as seen here:

transports?: Transport[] | Transport;

in containers, if you do this it will result in an error that says existing.slice doesn't exist

Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Spotted one potential issue?

lib/winston/container.js Outdated Show resolved Hide resolved
@Tanuel Tanuel requested a review from DABH January 2, 2023 09:27
@DABH
Copy link
Contributor

DABH commented Jan 2, 2023

Looks good, thanks again!

@DABH DABH merged commit eec59af into winstonjs:master Jan 2, 2023
renovate bot referenced this pull request in tsangste/nx-package-test Sep 21, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@swc/helpers](https://swc.rs)
([source](https://togithub.com/swc-project/swc)) | [`0.5.1` ->
`0.5.2`](https://renovatebot.com/diffs/npm/@swc%2fhelpers/0.5.1/0.5.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/@swc%2fhelpers/0.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@swc%2fhelpers/0.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@swc%2fhelpers/0.5.1/0.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@swc%2fhelpers/0.5.1/0.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [winston](https://togithub.com/winstonjs/winston) | [`3.8.2` ->
`3.10.0`](https://renovatebot.com/diffs/npm/winston/3.8.2/3.10.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/winston/3.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/winston/3.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/winston/3.8.2/3.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/winston/3.8.2/3.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>swc-project/swc (@&#8203;swc/helpers)</summary>

###
[`v0.5.2`](https://togithub.com/swc-project/swc/compare/c77f175ace114c12a783b387c42002de1c21ce3a...d15eaf05cd50dc4700d0e2ceeee828bced1a1f74)

[Compare
Source](https://togithub.com/swc-project/swc/compare/c77f175ace114c12a783b387c42002de1c21ce3a...d15eaf05cd50dc4700d0e2ceeee828bced1a1f74)

</details>

<details>
<summary>winstonjs/winston (winston)</summary>

###
[`v3.10.0`](https://togithub.com/winstonjs/winston/releases/tag/v3.10.0)

[Compare
Source](https://togithub.com/winstonjs/winston/compare/v3.9.0...v3.10.0)

- Avoid potential github issues - relax engines node requirement in
package.json
[`fc9c83d`](https://togithub.com/winstonjs/winston/commit/fc9c83d)
- Export Logger class
([#&#8203;2181](https://togithub.com/winstonjs/winston/issues/2181))
[`eda40ef`](https://togithub.com/winstonjs/winston/commit/eda40ef)
- Added Lazy option to file transport
([#&#8203;2317](https://togithub.com/winstonjs/winston/issues/2317))
[`f7e7f2f`](https://togithub.com/winstonjs/winston/commit/f7e7f2f)
- Bump eslint from 8.32.0 to 8.44.0
([#&#8203;2321](https://togithub.com/winstonjs/winston/issues/2321))
[`de2e887`](https://togithub.com/winstonjs/winston/commit/de2e887)
-
docs([#&#8203;2319](https://togithub.com/winstonjs/winston/issues/2319)):
Syntax error on README.md
([#&#8203;2320](https://togithub.com/winstonjs/winston/issues/2320))
[`fcc69ec`](https://togithub.com/winstonjs/winston/commit/fcc69ec)
- fix(types): Allow any object to be passed as meta to logger.profile
([#&#8203;2314](https://togithub.com/winstonjs/winston/issues/2314))
[`9d6001a`](https://togithub.com/winstonjs/winston/commit/9d6001a)
- Bump [@&#8203;types/node](https://togithub.com/types/node) from
18.11.18 to 20.3.1
([#&#8203;2313](https://togithub.com/winstonjs/winston/issues/2313))
[`06e3165`](https://togithub.com/winstonjs/winston/commit/06e3165)
- Update supported Node versions and run npm audit fix
([#&#8203;2315](https://togithub.com/winstonjs/winston/issues/2315))
[`61e2f5b`](https://togithub.com/winstonjs/winston/commit/61e2f5b)
- Bump [@&#8203;babel/core](https://togithub.com/babel/core) from
7.20.12 to 7.22.1
([#&#8203;2309](https://togithub.com/winstonjs/winston/issues/2309))
[`7643ad6`](https://togithub.com/winstonjs/winston/commit/7643ad6)

###
[`v3.9.0`](https://togithub.com/winstonjs/winston/blob/HEAD/CHANGELOG.md#v390)

[Compare
Source](https://togithub.com/winstonjs/winston/compare/v3.8.2...v3.9.0)

##### Functionality changes

- Handle undefined errors in getAllInfo in exception-handler in
[https://github.com/winstonjs/winston/pull/2208](https://togithub.com/winstonjs/winston/pull/2208);
thanks to new contributor
[@&#8203;eivindrs](https://togithub.com/eivindrs)
- fix: properly allow passing non-array transport in
[https://github.com/winstonjs/winston/pull/2256](https://togithub.com/winstonjs/winston/pull/2256);
thanks to new contributor [@&#8203;Tanuel](https://togithub.com/Tanuel)
- fix [#&#8203;1732](https://togithub.com/winstonjs/winston/issues/1732)
(Http Transport uses JSON format options as request options) in
[https://github.com/winstonjs/winston/pull/2272](https://togithub.com/winstonjs/winston/pull/2272);
thanks to new contributor
[@&#8203;MoritzLoewenstein](https://togithub.com/MoritzLoewenstein)
(minor version bump per comment on the issue)
- fix: add guard clause to prevent FD leak in
[https://github.com/winstonjs/winston/pull/2301](https://togithub.com/winstonjs/winston/pull/2301);
thanks to new contributor
[@&#8203;td-tomasz-joniec](https://togithub.com/td-tomasz-joniec)

##### Dependency updates by
[@&#8203;dependabot](https://togithub.com/dependabot) + CI autotesting

- Bump eslint from 8.23.0 to 8.32.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/winstonjs/winston/pull/2209](https://togithub.com/winstonjs/winston/pull/2209),
[https://github.com/winstonjs/winston/pull/2236](https://togithub.com/winstonjs/winston/pull/2236),
[https://github.com/winstonjs/winston/pull/2258](https://togithub.com/winstonjs/winston/pull/2258),
&
[https://github.com/winstonjs/winston/pull/2271](https://togithub.com/winstonjs/winston/pull/2271)
- Bump [@&#8203;babel/core](https://togithub.com/babel/core) from 7.19.0
to 7.20.12 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/winstonjs/winston/pull/2206](https://togithub.com/winstonjs/winston/pull/2206),
[https://github.com/winstonjs/winston/pull/2234](https://togithub.com/winstonjs/winston/pull/2234),
[https://github.com/winstonjs/winston/pull/2259](https://togithub.com/winstonjs/winston/pull/2259),
&
[https://github.com/winstonjs/winston/pull/2275](https://togithub.com/winstonjs/winston/pull/2275)
- Bump [@&#8203;types/node](https://togithub.com/types/node) from 18.0.0
to 18.11.18 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/winstonjs/winston/pull/2215](https://togithub.com/winstonjs/winston/pull/2215),
[https://github.com/winstonjs/winston/pull/2235](https://togithub.com/winstonjs/winston/pull/2235),
&
[https://github.com/winstonjs/winston/pull/2264](https://togithub.com/winstonjs/winston/pull/2264)
- Bump [@&#8203;babel/preset-env](https://togithub.com/babel/preset-env)
from 7.19.0 to 7.20.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/winstonjs/winston/pull/2218](https://togithub.com/winstonjs/winston/pull/2218)
&
[https://github.com/winstonjs/winston/pull/2244](https://togithub.com/winstonjs/winston/pull/2244)
- Bump safe-stable-stringify from 2.3.1 to 2.4.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/winstonjs/winston/pull/2217](https://togithub.com/winstonjs/winston/pull/2217)
&
[https://github.com/winstonjs/winston/pull/2292](https://togithub.com/winstonjs/winston/pull/2292)
- Bump [@&#8203;babel/cli](https://togithub.com/babel/cli) from 7.18.10
to 7.19.3 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/winstonjs/winston/pull/2216](https://togithub.com/winstonjs/winston/pull/2216)
- Bump json5 from 2.2.1 to 2.2.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/winstonjs/winston/pull/2260](https://togithub.com/winstonjs/winston/pull/2260)

##### Documentation changes

- Fix readme typo in
[https://github.com/winstonjs/winston/pull/2230](https://togithub.com/winstonjs/winston/pull/2230);
thanks to new contributor
[@&#8203;aretecode](https://togithub.com/aretecode)
- create new example for ready to use in
[https://github.com/winstonjs/winston/pull/2240](https://togithub.com/winstonjs/winston/pull/2240);
thanks to new contributor
[@&#8203;myagizmaktav](https://togithub.com/myagizmaktav)
-   minor fixes to publishing.md

##### Build Infrastructure changes

- GitHub Workflows security hardening in
[https://github.com/winstonjs/winston/pull/2252](https://togithub.com/winstonjs/winston/pull/2252);
thanks to new contributor
[@&#8203;sashashura](https://togithub.com/sashashura)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/tsangste/nx-package-test).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==-->

---------

Co-authored-by: Steven Tsang <steven.tsang@globacap.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot mentioned this pull request Mar 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants