Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "conform with RFC 5424" #349

Closed
wants to merge 1 commit into from
Closed

Revert "conform with RFC 5424" #349

wants to merge 1 commit into from

Conversation

dcbartlett
Copy link

This reverts commit 651b13e.

This is to fix the fact that this commit broke the way levels are handled with winston. This restores the levels to a working order.

dcbartlett referenced this pull request Jan 20, 2014
update severity codes to be conform with the Syslog Protocol (RFC 5424)
@guoyk93
Copy link

guoyk93 commented Apr 21, 2014

I strongly agree with you.
In fact, the current order of syslog levels is totally reversed.
Took me tens of minutes to figure out what's going wrong.

@Kuniwak
Copy link

Kuniwak commented May 5, 2014

+1

@indexzero
Copy link
Member

Yes you are all right. We messed up in merging 651b13e. Now we know this is definitely breaking so it will go into winston@1.0.0.

@indexzero
Copy link
Member

Closing this in favor of #406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants