"flush" event should always fire after "flush" call #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@compulim these all sound reasonable (talking of your other PR as well). Having not run into specific issues here, could you perhaps create a test case that previously failed without these? That would be super helpful for preventing regressions. |
|
Will include commits from #447. @jcrugzz I have implemented tests. But since it's about racing conditions between Is it okay to submit such tests? |
|
@compulim that sounds fine. seems like it has to do with azure having a slower filesystem where this is more pronounced. |
|
I have included two tests for the fix. Thanks! |
jcrugzz
added a commit
that referenced
this pull request
Sep 15, 2014
"flush" event should always fire after "flush" call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If nothing to flush, there will be no "flush" event from native stream.
Thus, the "open" event will never be fired, see
_createStream.createAndFlushfunction, line 436 of file.js.That means,
self.openingwill never set to false and no logs will be ever written to disk.To prevent this from happening, we will always fire "flush" event despite there are anything to flush or not.