Issue #566 maxFiles doesn't seem to behave as expected #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 @nimrod-becker could you add a test for this? |
|
Sure, actually there was a test especially for that case. However, the test always returned success (even though in fact there were 6 log files instead of three...). I've fixed the test, verified it's failing with the original code of file transport and working with the fix. |
| } else { | ||
| // The other files should be exist | ||
| assert.doesNotThrow(function () { | ||
| fs.statSync(fullpath); |
There was a problem hiding this comment.
Minor nit: 2-space tabs here.
|
Sorry about that :) fixed. |
|
@nimrod-becker will check it out again today and merge it if all is kosher. |
|
any news ? :) |
|
Works! 👍 |
indexzero
added a commit
that referenced
this pull request
Mar 16, 2015
Issue #566 maxFiles doesn't seem to behave as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #566, when using maxFiles (with tailsble = false) deleting the oldest file (in _checkMaxFilesIncrementing) is not behaving as expected.
Calculating the target to delete, the log number should be (oldest !== 0 ? oldest : '') .