Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update file.js - objectMode writable stream #632

Closed
wants to merge 2 commits into from
Closed

Update file.js - objectMode writable stream #632

wants to merge 2 commits into from

Commits on May 18, 2015

  1. Update file.js - objectMode writable stream 

    Appending this.eol explicitly to the result that common.log returns makes the output always become a string. That eliminates the possibility of piping js objects to the writable stream (which could be extremely handy for some cases). The proposed change won't break the code as the only case for the output not to be an object would be if this.stringify is explicitly rewritten to return objects (i.e. transport.stringify = function(obj){return obj})
    @stambata
    stambata committed May 18, 2015
    Configuration menu
    Copy the full SHA
    1912908 View commit details
    Browse the repository at this point in the history

  2. Update file.js

    @stambata
    stambata committed May 18, 2015
    Configuration menu
    Copy the full SHA
    fad1562 View commit details
    Browse the repository at this point in the history