Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node.js logo #39

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Add Node.js logo #39

merged 3 commits into from
Dec 7, 2023

Conversation

jasnell
Copy link
Contributor

@jasnell jasnell commented Dec 7, 2023

jasnell
jasnell commented Dec 7, 2023
View reviewed changes
main.jsx Show resolved Hide resolved
jasnell
jasnell commented Dec 7, 2023
View reviewed changes
main.jsx Outdated Show resolved Hide resolved
@lucacasonato
Copy link
Member

I'm not sure restrict: "horizontal" is actually implemented. I'll take a look.

@jasnell
Copy link
Contributor Author

jasnell commented Dec 7, 2023

It's fine if it's not. I tried restrict: 'vertical' but it made the logo way too small relative to the others.

@jasnell jasnell merged commit 14d4c8d into main Dec 7, 2023
@jasnell jasnell deleted the jasnell-nodejs-logo branch December 7, 2023 17:33
@thescientist13 thescientist13 mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasnell @lucacasonato @Ethan-Arrowood