Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create:settings command #37

Merged
merged 7 commits into from
Oct 6, 2021

Conversation

RomainMazB
Copy link
Contributor

Discussed here: wintercms/winter#201

@LukeTowers
Copy link
Member

Side note, would it instead be better to have create:settings rather than a flag on create:model?

Co-authored-by: Jack Wilkinson <31214002+jaxwilko@users.noreply.github.com>
@RomainMazB
Copy link
Contributor Author

Side note, would it instead be better to have create:settings rather than a flag on create:model?

You are the one who determine that, just let me know.

My thoughts on that:
Upside: less verbose, stubs directory structure cleaner
Downside: less intuitive for beginners: we create a settings but it's created into the models directory

@LukeTowers
Copy link
Member

@RomainMazB I think I prefer create:settings Author.Plugin ?OptionalSettingsClassOverride rather than create:model Author.Plugin SettingsClass --settings. @wintercms/maintainers any thoughts?

@LukeTowers
Copy link
Member

@RomainMazB let's go with create:settings instead, and if it's possible (and not already done so) we should have a success message after the files are created that lists the files that were created as a result of the command so that it's very clear where their files were created and what they are.

@RomainMazB RomainMazB changed the title Add --settings option to create:model command Add create:settings command Oct 5, 2021
@RomainMazB
Copy link
Contributor Author

@RomainMazB let's go with create:settings instead, and if it's possible (and not already done so) we should have a success message after the files are created that lists the files that were created as a result of the command so that it's very clear where their files were created and what they are.

create:settings is now ok.
To list the files created during all the create:, we should improve the GeneratorCommand class which only displays a successful message atm.

I'm on it :)

@LukeTowers LukeTowers added this to the v1.1.7 milestone Oct 6, 2021
LukeTowers added a commit to wintercms/docs that referenced this pull request Oct 6, 2021
@LukeTowers LukeTowers merged commit b774511 into wintercms:develop Oct 6, 2021
LukeTowers added a commit to wintercms/docs that referenced this pull request Oct 6, 2021
LukeTowers added a commit that referenced this pull request Nov 13, 2021
* develop:
  Add create:settings command (#37)
  Display generated files in generator commands (#52)
  Add (array) $data to all mail events (#49)
  fix typo after Luke's last cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants