Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default name to commands for lazy loading #63

Merged
merged 4 commits into from
Dec 17, 2021
Merged

Add default name to commands for lazy loading #63

merged 4 commits into from
Dec 17, 2021

Conversation

bennothommo
Copy link
Member

@bennothommo bennothommo added this to the v1.2.0 milestone Dec 14, 2021
@LukeTowers
Copy link
Member

What needs to be done in order to support this for plugin registered commands?

@bennothommo
Copy link
Member Author

@LukeTowers I think if they define $defaultName as a property with the commands, the lazy loading will kick in automatically. At the very least, I don't believe they've disabled eager-loading commands in the old fashion.

@LukeTowers LukeTowers merged commit 289242e into wip/1.2 Dec 17, 2021
@LukeTowers LukeTowers deleted the wip/1.2-lazy-load-commands branch December 17, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeTowers LukeTowers LukeTowers left review comments

Assignees
No one assigned
Labels
Status: Completed Type: Maintenance
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bennothommo @LukeTowers