Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for translation strings in FormField->options() #1192

Merged
merged 9 commits into from
Sep 26, 2024
Merged

Add support for translation strings in FormField->options() #1192

merged 9 commits into from
Sep 26, 2024

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Aug 26, 2024

  • add valueLabel() method
  • add support for translation strings in options() method

@mjauvin mjauvin added enhancement PRs that implement a new feature or substantial change needs review Issues/PRs that require a review from a maintainer labels Aug 26, 2024
@mjauvin mjauvin self-assigned this Aug 26, 2024
@mjauvin @LukeTowers
check if value is a string
6813194 
Co-authored-by: Luke Towers <luke@luketowers.ca>
bennothommo
bennothommo previously requested changes Sep 2, 2024
View reviewed changes
modules/backend/classes/FormField.php Outdated Show resolved Hide resolved
modules/backend/classes/FormField.php Outdated Show resolved Hide resolved
modules/backend/classes/FormField.php Outdated Show resolved Hide resolved
@LukeTowers LukeTowers changed the title Improve FormField Add support for translation strings in FormField->options() Sep 26, 2024
@LukeTowers
Copy link
Member

@mjauvin are any changes to the docs required?

@mjauvin
Copy link
Member Author

mjauvin commented Sep 26, 2024

@mjauvin are any changes to the docs required?

Not really, it was documented when the counterpart to this was added to Backend\Widgets\Form::getOptionsFromModel().

@LukeTowers LukeTowers added Status: Completed and removed enhancement PRs that implement a new feature or substantial change labels Sep 26, 2024
@LukeTowers LukeTowers added this to the 1.2.7 milestone Sep 26, 2024
@LukeTowers LukeTowers added maintenance PRs that fix bugs, are translation changes or make only minor changes and removed needs review Issues/PRs that require a review from a maintainer labels Sep 26, 2024
@LukeTowers LukeTowers merged commit 35d7e2b into develop Sep 26, 2024
11 checks passed
@LukeTowers LukeTowers deleted the improve-form-field branch September 26, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeTowers LukeTowers LukeTowers left review comments

@bennothommo bennothommo bennothommo left review comments

Assignees

@mjauvin mjauvin

Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Milestone
1.2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@mjauvin @LukeTowers @bennothommo