Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow command names to contain number #1207

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Allow command names to contain number #1207

merged 3 commits into from
Sep 26, 2024

Conversation

damsfx
Copy link
Contributor

@damsfx damsfx commented Sep 18, 2024

Allow command name to contains numbers, eg:

php artisan create:command Acme.MyPlugin4You MyCommand

@damsfx
Allow command name to contains number
77c7f4d 
Allow command name to contains number, eg:
```bash
php artisan create:command Acme.MyPlugin4You MyCommand
```
@LukeTowers
Copy link
Member

@damsfx can you add some unit tests for this? I still want it to create valid class names, which can't start with a number IIRC

@LukeTowers LukeTowers added needs response Issues/PRs where a maintainer is awaiting a response from the submitter maintenance PRs that fix bugs, are translation changes or make only minor changes labels Sep 26, 2024
@damsfx
Copy link
Contributor Author

damsfx commented Sep 26, 2024

@damsfx can you add some unit tests for this? I still want it to create valid class names, which can't start with a number IIRC

Done :

  • Plugin and command names can contain a number, but they can't start with it
  • Add tests

@mjauvin mjauvin changed the title Allow command name to contains number Allow command name to contain number Sep 26, 2024
@LukeTowers LukeTowers added Status: Completed and removed needs response Issues/PRs where a maintainer is awaiting a response from the submitter labels Sep 26, 2024
@LukeTowers LukeTowers added this to the 1.2.7 milestone Sep 26, 2024
@LukeTowers LukeTowers merged commit 5885b45 into wintercms:develop Sep 26, 2024
10 checks passed
@LukeTowers LukeTowers changed the title Allow command name to contain number Allow command names to contain number Sep 26, 2024
@damsfx damsfx deleted the patch-allowing-number-in-command-name branch September 27, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Milestone
1.2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@damsfx @LukeTowers