-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event logs deletion with filters #1252
base: develop
Are you sure you want to change the base?
Conversation
- better change detection on form fields - close popup after user confirmation
@damsfx what do you think about instead adding date filters to the list itself and then making a PR to add support for a special "select all" mode that allows you to select all records that match the current query (like gmail has)? |
Could even make the select all text even more useful by adding a count to it ("Select all records that match this search (402)") |
@LukeTowers This would be a good improvement for the event manager and certainly the best UI/UX. My tests in this direction are meeting several challenges:
In addition, for the selection of items not displayed in the list, what do you think is the best solution for adding these capabilities to the controller?
|
The search behaviour can be configured by setting I'd prefer the expanded selection logic to be added to the ListController behavior, it would be useful in pretty much every list. |
While the event log list allows you to delete events in a bulk fashion by filtering the list with a keyword, then selecting all the events and clicking on the "Delete selected" button, if the log includes more events responding to the query than the list can display, you need to repeat the action several times to delete all the events.
This PR provides a new button to display a pop-up window to the user, allowing him to enter a search term and date range to obtain the set of events matching the criteria, which will be deleted after confirmation.