Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event logs deletion with filters #1252

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

damsfx
Copy link
Contributor

@damsfx damsfx commented Nov 15, 2024

While the event log list allows you to delete events in a bulk fashion by filtering the list with a keyword, then selecting all the events and clicking on the "Delete selected" button, if the log includes more events responding to the query than the list can display, you need to repeat the action several times to delete all the events.

This PR provides a new button to display a pop-up window to the user, allowing him to enter a search term and date range to obtain the set of events matching the criteria, which will be deleted after confirmation.

image

image

@LukeTowers
Copy link
Member

@damsfx what do you think about instead adding date filters to the list itself and then making a PR to add support for a special "select all" mode that allows you to select all records that match the current query (like gmail has)?

Untitled 3 Untitled 2

@LukeTowers
Copy link
Member

Could even make the select all text even more useful by adding a count to it ("Select all records that match this search (402)")

@damsfx
Copy link
Contributor Author

damsfx commented Nov 16, 2024

@LukeTowers This would be a good improvement for the event manager and certainly the best UI/UX.

My tests in this direction are meeting several challenges:

  • The list search field is too generic and searches the different model properties.
  • The search field doesn't allow searching for special characters like %.

In addition, for the selection of items not displayed in the list, what do you think is the best solution for adding these capabilities to the controller?

  • Add them to \Backend\Behaviors\ListController.
  • Create a new type of list controller
  • Add them only to \System\Controllers\EventLogs.

@LukeTowers
Copy link
Member

The search behaviour can be configured by setting searchable: false on columns that you don't want to be searched on.

I'd prefer the expanded selection logic to be added to the ListController behavior, it would be useful in pretty much every list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants