-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add support for PHP 8 #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests will be allowed to fail for now, as we don't officially support PHP 8.
Co-authored-by: Kanstantsin K <kk@tolkam.by>
… BackendController (#5493) Co-authored-by: Kanstantsin K <kk@tolkam.by>
Since we are now relying on different versions of some dependencies depending on whether PHP 7 or 8 is used, we can no longer lock the PHP version down.
- No longer need AssertGD in main repo, as it was only used for library tests. - Allow different version of ArraySubset asserts depending on PHP version
bennothommo
added
Status: Completed
maintenance
PRs that fix bugs, are translation changes or make only minor changes
labels
Mar 21, 2021
LukeTowers
pushed a commit
that referenced
this pull request
Apr 13, 2021
Added reportcontainer.less to the compiler
arvislacis
added a commit
to arvislacis/winter
that referenced
this pull request
Dec 6, 2021
arvislacis
added a commit
to arvislacis/winter
that referenced
this pull request
Dec 18, 2021
This reverts commit 732a9bc.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.