Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add support for PHP 8 #2

Merged
merged 14 commits into from
Mar 6, 2021
Merged

[WIP] Add support for PHP 8 #2

merged 14 commits into from
Mar 6, 2021

Conversation

bennothommo
Copy link
Member

No description provided.

bennothommo and others added 14 commits November 20, 2020 11:24
These tests will be allowed to fail for now, as we don't officially support PHP 8.
Co-authored-by: Kanstantsin K <kk@tolkam.by>
… BackendController (#5493)

Co-authored-by: Kanstantsin K <kk@tolkam.by>
Since we are now relying on different versions of some dependencies depending on whether PHP 7 or 8 is used, we can no longer lock the PHP version down.
- No longer need AssertGD in main repo, as it was only used for library tests.
- Allow different version of ArraySubset asserts depending on PHP version
@bennothommo bennothommo added this to the v1.1.2 milestone Mar 4, 2021
@LukeTowers LukeTowers merged commit c71e1e3 into develop Mar 6, 2021
@LukeTowers LukeTowers deleted the wip/php-8-testing branch March 6, 2021 08:41
@bennothommo bennothommo added Status: Completed maintenance PRs that fix bugs, are translation changes or make only minor changes labels Mar 21, 2021
LukeTowers pushed a commit that referenced this pull request Apr 13, 2021
arvislacis added a commit to arvislacis/winter that referenced this pull request Dec 6, 2021
arvislacis added a commit to arvislacis/winter that referenced this pull request Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants