Add winter:test command

[RomainMazB]

First of the console command discussed here #201

Accepts any review from anyone out there.

I did not found how it would be possible to display the phpunit running test. As of today it runs the tests "silently" and then output the results.

plugin-test-command.mp4

[bennothommo]

@RomainMazB it's definitely possible to get the output happening in real-time - see the Dusk command class here, which does the same thing for Dusk tests: https://github.com/wintercms/wn-dusk-plugin/blob/main/console/Dusk.php. I would prefer that the output be in real-time if possible.

The key is to use the Process component from Symfony.

[RomainMazB]

@bennothommo sure, I'd definitely prefer too. Thanks for pointed out how to do this, I'll definitely implement this

[LukeTowers]

Might be nice to have it as winter:test ?target where target could be blank for the application's test suite or a specific plugin, and also forward any arguments / options / filters to the phpunit command (example: I use the --filter option a lot to run a specific single test)

[RomainMazB]

Ok, improvements made.
@LukeTowers to proxy all the phpunit filter we are forced to ignore validation (or create a 50 lines signature to describe all the available options). The same is done into the Laravel's core test command: https://github.com/nunomaduro/collision/blob/stable/src/Adapters/Laravel/Commands/TestCommand.php#L48-L53

A quick view of the final results.
https://user-images.githubusercontent.com/53976837/124030370-68e5b980-d9f6-11eb-893f-c6d57cc45b58.mp4

[LukeTowers]

@RomainMazB does the core tests differentiate between the CMS tests and the library tests? @bennothommo should we have a way to trigger them separately or together?

[bennothommo]

@LukeTowers we could define all the tests as separate suites in the phpunit.xml file and it would allow us to run all tests together, but there's no way to separate the test results - not sure if that's necessary a problem for people.

We used to combine the library and core tests, but I separated them during the L6 update because tests were failing when core PRs were relying on unmerged library PRs.

[RomainMazB]

In the latest commit, we can now pass a custom configuration file using --configuration option.

If none is defined, it looks for phpunit.xml file and fallback to phpunit.xml.dist.

Need precision about my comment on @bennothommo review about exists() and the final thoughts on the library and core tests to continue.

[github-actions]

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

[jaxwilko]

I've made a few changes to improve the arguments passthrough to phpunit, there is an issue where if phpunit arguments are passed before the command arguments then the command args aren't parsed.

Seems to be an issue from Symfony\Component\Console\Input\ArgvInput. I shall look into it and see what I can find :)

[RomainMazB]

@LukeTowers @bennothommo.
I've been toying with the ArgvInput symfony component to find the cause of the issue mentioned by @jaxwilko.

The issue is not directly the fact that we pass a PHPUnit argument before --plugin or --core, but the fact the winter:test command doesn't define those options, which raise a RuntimeException, the exception is silently hidden by the ignoreValidationErrors rule we are using and present in the Symfony Command class here: https://github.com/symfony/symfony/blob/e34cd7dd2c6d0b30d24cad443b8f964daa841d71/src/Symfony/Component/Console/Command/Command.php#L248-L252

This makes the options to not be correctly set and runs the command without any options at all. I'm afraid that we won't be able to allow phpunit options before the winter:test command's ones.

I've added a section in the documentation emphasizing the fact that phpunit options should be passed after the command's options. which works well:

Completed