Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore full Laravel Mailer behavior #610

Closed
wants to merge 38 commits into from
Closed

Restore full Laravel Mailer behavior #610

wants to merge 38 commits into from

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Jul 15, 2022

Related to wintercms/storm#7

mjauvin and others added 30 commits December 13, 2020 13:01
@mjauvin
Restore full Laravel Mailer behavior
eedb420
@mjauvin
add Mailer tests
f56c617
@mjauvin
minor tweaks; add plethora of tests
7a935be
@mjauvin
add a few comments
018b0b2
@mjauvin
single line assignment
7ba918d
@mjauvin
no new line for else block
d88f893
@mjauvin
simplify setUp()
6bf22a6
@mjauvin
tidyup tests a bit
96ecbb0
@mjauvin
missed one
5a93411
@mjauvin @bennothommo
update return type
b9d976c 
Co-authored-by: Ben Thomson <git@alfreido.com>
@mjauvin @bennothommo
use verbose code
8ce5c35 
Co-authored-by: Ben Thomson <git@alfreido.com>
@mjauvin @bennothommo
Apply suggestions from code review
7a823e3 
Co-authored-by: Ben Thomson <git@alfreido.com>
@mjauvin
use !is_null() instead of isset()
0fb2bcd
@mjauvin
add default argument values
3ee9045
@mjauvin
add missing spaces around =
afb978c
@mjauvin
Merge branch 'develop' into restore-laravel-mailer-behavior
9dfee03
@mjauvin
make sure we only handle string view names
1ca8834
@mjauvin
Merge branch 'develop' into restore-laravel-mailer-behavior
85f6acb
@bennothommo
Add version.yaml processor, update versioning to use this processor
d386a41
@bennothommo
Tweaks to version/update unit tests
b736df2
@mjauvin
bail out if the view is not a string template name
ec3d477
@mjauvin
Merge branch 'develop' into restore-laravel-mailer-behavior
925d882
@mjauvin
Merge branch 'wip/version-yaml-processing' into restore-laravel-maile…
a769cd2 
…r-behavior
@mjauvin
only work with string template names
d2f3acf
@LukeTowers
Merge branch 'develop' into restore-laravel-mailer-behavior
fea5826
@mjauvin
Merge branch 'develop' into restore-laravel-mailer-behavior
008213e
@mjauvin
Merge branch 'develop' into restore-laravel-mailer-behavior
cfa410d
@mjauvin
Merge branch 'wip/1.2' into restore-laravel-mailer-behavior
48e927a
@mjauvin
Merge branch 'wip/1.2' into restore-laravel-mailer-behavior
2a007fb
@mjauvin
Merge branch 'wip/1.2' into restore-laravel-mailer-behavior
d0a0717
@mjauvin mjauvin self-assigned this Jul 15, 2022
@mjauvin mjauvin added this to the v1.2.1 milestone Jul 15, 2022
@mjauvin mjauvin marked this pull request as draft July 15, 2022 17:56
@bennothommo bennothommo modified the milestones: v1.2.1, v1.2.2 Sep 12, 2022
@github-actions
Copy link

This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months.
If you intend to continue working on this pull request, please respond within 3 days.
If this pull request is critical for your business, please reach out to us at wintercms@luketowers.ca.

@github-actions github-actions bot added the stale Issues/PRs that have had no activity and may be archived label Mar 14, 2023
@bennothommo bennothommo removed the stale Issues/PRs that have had no activity and may be archived label Mar 15, 2023
@mjauvin
Copy link
Member Author

mjauvin commented Mar 28, 2023

won't complete this work.

@mjauvin mjauvin closed this Mar 28, 2023
@mjauvin mjauvin removed this from the v1.2.2 milestone Mar 28, 2023
@LukeTowers LukeTowers deleted the wip/restore-laravel-mailer-behavior branch March 30, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mjauvin mjauvin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjauvin @bennothommo @LukeTowers