Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PDF 'image' #996

Closed
wants to merge 1 commit into from
Closed

Conversation

AIC-BV
Copy link
Contributor

@AIC-BV AIC-BV commented Oct 18, 2023

See #990
PDF thumb path needs to be provided

@AIC-BV AIC-BV marked this pull request as draft October 18, 2023 13:52
@AIC-BV
Copy link
Contributor Author

AIC-BV commented Oct 18, 2023

@LukeTowers
@bennothommo
Can you help me finish this?

First file is saved.
Second file has just been uploaded and not yet saved.
All it needs is a path to a PDF image/icon and support for other types if you want
image

@bennothommo
Copy link
Member

@AIC-BV sorry, just so I'm clear, is this a fileupload type field that you have set to mode: image and are uploading a PDF to it?

@AIC-BV
Copy link
Contributor Author

AIC-BV commented Oct 20, 2023

@AIC-BV sorry, just so I'm clear, is this a fileupload type field that you have set to mode: image and are uploading a PDF to it?

It might be 🤭😇

@AIC-BV
Copy link
Contributor Author

AIC-BV commented Oct 20, 2023

I tried to file mode and I don't like it at all, there is no preview and thus you have to open each file/image individually to actually know what it is. This significantly lowers efficiency.
You have to check each file manually. I really need the thumbnails.

It is possible that a client uploads a PDF or IMAGE
The mode IMAGE supports it perfectly fine. Only thing missing is a thumbnail for file types.

@bennothommo
Copy link
Member

Arguably, a PDF is not an image. It is a file, and yes, we don't have previews of files because it's very likely we can't generate a preview of some file types.

@AIC-BV
Copy link
Contributor Author

AIC-BV commented Oct 27, 2023

Its up to you!
I'm fine with not having a PDF icon/Word icon/... it just feels more complete.
Having support for the most common filetypes is better than none at all?
Anyways, it works either way!

@bennothommo
Copy link
Member

@AIC-BV I do like the way that the image type file uploads present, so I'm not adverse to us using the same "style" for standard file uploads too, but we would need some sort of preview for every file type (with a fallback, I would image, of a file icon with perhaps the extension within, kinda like what you suggested earlier).

Might be worth mocking that up first so we can see how it would look.

@LukeTowers
Copy link
Member

Will continue in #1045

@LukeTowers LukeTowers closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants