feat: add UnknownStrategy enum for future-proofing #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
When introducing some message types, clients that are not ready to receive them yet might react in improper ways.
iOS warns about all received unknown messages while Android and Web ignore unknown message types.
This isn't currently unified between clients and there's no way of choosing a different approach depending on the newly introduced message type.
Solutions
As proposed in the internal RFC, add a new field called
unknownStrategy
to be sent beside the actual message content. Ifcontent
is NULL/NONE, theunknownStrategy
can give a hint of what to do and how to handle such message.PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.