Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tag logging #2536

Merged
merged 4 commits into from
Feb 23, 2024
Merged

chore: fix tag logging #2536

merged 4 commits into from
Feb 23, 2024

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented Feb 22, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  1. When adding user information to log tags, we're always passing clientId = null, as the clientIdFlow is always null.
  2. We are not properly parsing this case. Leading to null being always returned by getFromTag.

Solutions

  1. Properly add the clientId to logs.
  2. Handle the possibility of clientId being missing from log tags when parsing them.

Testing

  • Added tests to the tag parsing to make sure we support missing client data

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods requested review from saleniuk, a team, alexandreferris, MohamadJaara, Garzas and e-lisa and removed request for a team February 22, 2024 16:15
Copy link
Contributor

github-actions bot commented Feb 22, 2024

Test Results

2 795 tests   2 769 ✔️  3m 50s ⏱️
       7 suites       26 💤
       7 files           0

Results for commit b26684a.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 22, 2024

Datadog Report

All test runs 54a0176 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2683 129 8m 49.1s Link
kalium-jvm 0 0 0 2811 123 8m 44.04s Link

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/candidate@630462f). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2536   +/-   ##
====================================================
  Coverage                     ?   58.44%           
  Complexity                   ?        7           
====================================================
  Files                        ?     1172           
  Lines                        ?    45473           
  Branches                     ?     4307           
====================================================
  Hits                         ?    26576           
  Misses                       ?    16962           
  Partials                     ?     1935           
Files Coverage Δ
...Main/kotlin/com/wire/kalium/logger/KaliumLogger.kt 68.68% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 630462f...f233bde. Read the comment docs.

@vitorhugods vitorhugods disabled auto-merge February 23, 2024 10:08
@vitorhugods vitorhugods merged commit 23d2fca into release/candidate Feb 23, 2024
15 checks passed
@vitorhugods vitorhugods deleted the chore/fix-tag-logging branch February 23, 2024 10:08
@github-actions github-actions bot mentioned this pull request Feb 23, 2024
5 tasks
github-merge-queue bot pushed a commit that referenced this pull request Feb 26, 2024
Co-authored-by: Vitor Hugo Schwaab <vitor@schwaab.dev>
Co-authored-by: Mohamad Jaara <mohamad.jaara@wire.com>
jschumacher-wire pushed a commit that referenced this pull request Mar 6, 2024
Co-authored-by: Vitor Hugo Schwaab <vitor@schwaab.dev>
Co-authored-by: Mohamad Jaara <mohamad.jaara@wire.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants