-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix tag logging #2536
chore: fix tag logging #2536
Conversation
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2536 +/- ##
====================================================
Coverage ? 58.44%
Complexity ? 7
====================================================
Files ? 1172
Lines ? 45473
Branches ? 4307
====================================================
Hits ? 26576
Misses ? 16962
Partials ? 1935
Continue to review full report in Codecov by Sentry.
|
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
clientId = null
, as theclientIdFlow
is always null.null
being always returned bygetFromTag
.Solutions
clientId
to logs.clientId
being missing from log tags when parsing them.Testing
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.