Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Testservice now deployed via Ansible #3265

Merged
merged 7 commits into from
Jan 30, 2025
Merged

Conversation

mythsunwind
Copy link
Collaborator


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

This PR will make it possible to deploy the testservice via Ansible. The jar will be build inside a docker container to make it platform independent. The important part is also that encryptProteusStorage = true is now used in kalium testservice in order to use core-crypto library instead of old cryptobox.

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Test Results

3 411 tests  ±0   3 303 ✅ ±0   5m 40s ⏱️ -39s
  584 suites ±0     108 💤 ±0 
  584 files   ±0       0 ❌ ±0 

Results for commit 4bf5796. ± Comparison against base commit 76d2206.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 30, 2025

Datadog Report

Branch report: testservice-ansible
Commit report: c9f7f0b
Test service: kalium-jvm

✅ 0 Failed, 3303 Passed, 108 Skipped, 1m 4.16s Total Time

Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.90%. Comparing base (c6d3335) to head (4bf5796).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3265      +/-   ##
===========================================
- Coverage    54.44%   53.90%   -0.55%     
===========================================
  Files         1271     1303      +32     
  Lines        37018    37404     +386     
  Branches      3753     3770      +17     
===========================================
+ Hits         20156    20161       +5     
- Misses       15445    15833     +388     
+ Partials      1417     1410       -7     

see 62 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d3335...4bf5796. Read the comment docs.

@MohamadJaara MohamadJaara added this pull request to the merge queue Jan 30, 2025
Merged via the queue into develop with commit 4055696 Jan 30, 2025
22 of 23 checks passed
@MohamadJaara MohamadJaara deleted the testservice-ansible branch January 30, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants