Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore invalid leaf signature error on slow sync [WPB-15737] #3266

Merged

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jan 31, 2025

BugWPB-15737 [Android] app stuck on login


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

On non recoverable error Tried to add invalid LeafNode: Invalid LeafNode signature we are not ignoring this on slow sync during JOINING_MLS_CONVERSATIONS which is blocking user for using app

Solutions

Ignore this error during slow sync

@Garzas Garzas self-assigned this Jan 31, 2025
@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Test Results

3 357 tests  +1   3 249 ✅ +1   5m 59s ⏱️ +36s
  572 suites ±0     108 💤 ±0 
  572 files   ±0       0 ❌ ±0 

Results for commit 6d58a9d. ± Comparison against base commit ba4e228.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 31, 2025

Datadog Report

Branch report: fix/ignore-mls-error-on-joining-conversation
Commit report: bf67c35
Test service: kalium-jvm

✅ 0 Failed, 3249 Passed, 108 Skipped, 1m 1.43s Total Time

@Garzas Garzas enabled auto-merge January 31, 2025 10:22
@Garzas Garzas added this pull request to the merge queue Jan 31, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.52%. Comparing base (ba4e228) to head (6d58a9d).

Files with missing lines Patch % Lines
...onversation/JoinExistingMLSConversationsUseCase.kt 87.50% 0 Missing and 1 partial ⚠️
.../wire/kalium/network/exceptions/KaliumException.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/candidate    #3266      +/-   ##
=====================================================
- Coverage              54.52%   54.52%   -0.01%     
=====================================================
  Files                   1252     1252              
  Lines                  36623    36629       +6     
  Branches                3710     3712       +2     
=====================================================
+ Hits                   19968    19971       +3     
- Misses                 15253    15255       +2     
- Partials                1402     1403       +1     
Files with missing lines Coverage Δ
...ire/kalium/network/exceptions/NetworkErrorLabel.kt 100.00% <ø> (ø)
...onversation/JoinExistingMLSConversationsUseCase.kt 97.36% <87.50%> (-2.64%) ⬇️
.../wire/kalium/network/exceptions/KaliumException.kt 78.57% <0.00%> (-1.43%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba4e228...6d58a9d. Read the comment docs.

Merged via the queue into release/candidate with commit 1e85447 Jan 31, 2025
21 checks passed
@Garzas Garzas deleted the fix/ignore-mls-error-on-joining-conversation branch January 31, 2025 11:55
github-actions bot pushed a commit that referenced this pull request Jan 31, 2025
)

* fix: ignore invalid leaf signature error on slow sync

* ignore all 400 errors

* update upload artifact
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2025
) (#3267)

* fix: ignore invalid leaf signature error on slow sync

* ignore all 400 errors

* update upload artifact

Co-authored-by: Jakub Żerko <iot.zerko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 🚨 Potential breaking changes 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants