fix: Call stuck on Connecting state after joining a call or putting the app in background (WPB-15554)

[ohassine]

WPB-15554 [Android] Stuck on "Connecting..." after putting the app to the background/foreground multiple times

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

Call stuck on Connecting state after joining a call or putting the app in background

Causes (Optional)

We did some improvements here #3011 by making the app observes the call from cache instead of database, this makes the call stays on connecting screen forever when we kill and open the app again.

Solutions

Observe from DB

Needs releases with:

• GitHub link to other pull request

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Test Results

3 418 tests  ±0   3 310 ✅ ±0   5m 46s ⏱️ -15s
  584 suites ±0     108 💤 ±0 
  584 files   ±0       0 ❌ ±0 

Results for commit dba59a6. ± Comparison against base commit 82347b7.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.

com.wire.kalium.logic.feature.call.usecase.AnswerCallUseCaseTest ‑ givenACall_whenAnsweringIt_thenInvokeAnswerCallOnce[jvm]
com.wire.kalium.logic.feature.call.usecase.GetAllCallsWithSortedParticipantsUseCaseTest ‑ givenCallsFlowEmitsANewValue_whenUseCaseIsCollected_thenAssertThatTheUseCaseIsEmittingTheRightCalls[jvm]

com.wire.kalium.logic.feature.call.usecase.AnswerCallUseCaseTest ‑ givenAIncomingCall_whenAnsweringIt_thenInvokeAnswerCallOnce[jvm]
com.wire.kalium.logic.feature.call.usecase.ObserveEstablishedCallWithSortedParticipantsUseCaseTest ‑ givenCallFlowEmitsANewValue_whenUseCaseIsRunning_thenAssertThatTheUseCaseIsEmittingTheRightCalls[jvm]

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	call-stuck-connecting
Testbed	ubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

• Latency (nanoseconds (ns))

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results

Benchmark	Latency	microseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	689.47
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	541,841.64
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	1,345,113.09
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	22,148.72

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.84%. Comparing base (82347b7) to head (dba59a6).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3282      +/-   ##
===========================================
+ Coverage    50.82%   50.84%   +0.01%     
===========================================
  Files         1606     1605       -1     
  Lines        57243    57220      -23     
  Branches      5109     5109              
===========================================
- Hits         29094    29093       -1     
+ Misses       26134    26111      -23     
- Partials      2015     2016       +1     

see 8 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82347b7...dba59a6. Read the comment docs.

[datadog-wireapp]

Datadog Report

Branch report: call-stuck-connecting
Commit report: 1fe5566
Test service: kalium-jvm

✅ 0 Failed, 3310 Passed, 108 Skipped, 1m 0.53s Total Time