Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove folder when conversation list is empty [WPB-15892] #3285

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Feb 7, 2025

TaskWPB-15892 [Android] It should not be possible to create empty folders


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Because backend doesn't clean folders by itself we need to check if they are empty after conversation from folder removal

Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Test Results

3 515 tests  +2   3 407 ✅ +2   6m 29s ⏱️ +34s
  603 suites ±0     108 💤 ±0 
  603 files   ±0       0 ❌ ±0 

Results for commit b2270e3. ± Comparison against base commit 20791fd.

♻️ This comment has been updated with latest results.

@Garzas Garzas enabled auto-merge February 7, 2025 12:59
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe task is not only about removing folder after removing the last conversation from it. But also about creating an empty folder in "move to folder" flow. And this PR looks like doesn't solve it. 🤔

@borichellow
Copy link
Contributor

I believe task is not only about removing folder after removing the last conversation from it. But also about creating an empty folder in "move to folder" flow. And this PR looks like doesn't solve it. 🤔

nvm, found Android PR for that :)

@Garzas Garzas added this pull request to the merge queue Feb 7, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.84%. Comparing base (20791fd) to head (b2270e3).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3285      +/-   ##
===========================================
- Coverage    50.84%   50.84%   -0.01%     
===========================================
  Files         1607     1607              
  Lines        58052    58056       +4     
  Branches      5203     5204       +1     
===========================================
+ Hits         29514    29516       +2     
- Misses       26521    26524       +3     
+ Partials      2017     2016       -1     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20791fd...b2270e3. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/remove-empty-folder
Commit report: 95c7c82
Test service: kalium-jvm

✅ 0 Failed, 3407 Passed, 108 Skipped, 1m 0.59s Total Time

Merged via the queue into develop with commit c1b6eba Feb 7, 2025
24 checks passed
@Garzas Garzas deleted the fix/remove-empty-folder branch February 7, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants