Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update step-ca e2e integration test configuration #135

Closed
wants to merge 12 commits into from

Conversation

hslatman
Copy link
Contributor

@hslatman hslatman commented Jan 15, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Changes introduced in smallstep/certificates#1666 (and related PRs) changed some of the configuration values used in the e2e test.

Solutions

Updated and added properties to make the e2e test green again.

Needs releases with:

Testing

How to Test

  • Create a build of the step-ca container (e.g. docker build -t step-ca -f docker/Dockerfile .) from the certificates repo. Remote builds and image registries also work if configured correctly.
  • Run below commands
export STEPCA_NAME="step-ca"
export STEPCA_VERSION="latest"

cargo +nightly test --color=always --test e2e demo_should_succeed --manifest-path e2e-identity/Cargo.toml -- -Z unstable-options --show-output

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2024

CLA assistant check
All committers have signed the CLA.

@istankovic
Copy link
Member

@hslatman could you please provide more information on what this PR does?
Is it still relevant?

Before considering this for merging, could you please rebase your changes on top of latest main (please avoid merging main back into PR branches)?

@hslatman
Copy link
Contributor Author

@istankovic it looks like this can be closed. The older commits seem to be in the code base already: https://github.com/wireapp/rusty-jwt-tools/commits?author=hslatman. If the results of that e2e-identity are currently satisfactory, I believe all works as expected.

@istankovic
Copy link
Member

Oh, yes, great, thanks for looking into it. 👍
Closing.

@istankovic istankovic closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants