-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: update step-ca
e2e integration test configuration
#135
Conversation
As of smallstep/certificates@8997ce1, they're no longer enabled by default.
With smallstep/certificates@768a089, we changed the persisted OIDC ID token to contain the (potentially) transformed properties of the original.
@hslatman could you please provide more information on what this PR does? Before considering this for merging, could you please rebase your changes on top of latest |
@istankovic it looks like this can be closed. The older commits seem to be in the code base already: https://github.com/wireapp/rusty-jwt-tools/commits?author=hslatman. If the results of that |
Oh, yes, great, thanks for looking into it. 👍 |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Changes introduced in smallstep/certificates#1666 (and related PRs) changed some of the configuration values used in the e2e test.
Solutions
Updated and added properties to make the e2e test green again.
Needs releases with:
rusty-jwt-cli
smallstep/certificates#1670Testing
How to Test
step-ca
container (e.g.docker build -t step-ca -f docker/Dockerfile .
) from the certificates repo. Remote builds and image registries also work if configured correctly.PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.