-
Notifications
You must be signed in to change notification settings - Fork 28
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: crash about persistent websocket being started from background […
…WPB-6551] (#2745)
- Loading branch information
Showing
3 changed files
with
238 additions
and
23 deletions.
There are no files selected for viewing
57 changes: 57 additions & 0 deletions
57
app/src/main/kotlin/com/wire/android/feature/ShouldStartPersistentWebSocketServiceUseCase.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /* | ||
| * Wire | ||
| * Copyright (C) 2024 Wire Swiss GmbH | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see http://www.gnu.org/licenses/. | ||
| */ | ||
| package com.wire.android.feature | ||
|
|
||
| import com.wire.android.di.KaliumCoreLogic | ||
| import com.wire.kalium.logic.CoreLogic | ||
| import com.wire.kalium.logic.feature.user.webSocketStatus.ObservePersistentWebSocketConnectionStatusUseCase | ||
| import kotlinx.coroutines.flow.firstOrNull | ||
| import kotlinx.coroutines.withTimeoutOrNull | ||
| import javax.inject.Inject | ||
| import javax.inject.Singleton | ||
|
|
||
| @Singleton | ||
| class ShouldStartPersistentWebSocketServiceUseCase @Inject constructor( | ||
| @KaliumCoreLogic private val coreLogic: CoreLogic | ||
| ) { | ||
| suspend operator fun invoke(): Result { | ||
| return coreLogic.getGlobalScope().observePersistentWebSocketConnectionStatus().let { result -> | ||
| when (result) { | ||
| is ObservePersistentWebSocketConnectionStatusUseCase.Result.Failure -> Result.Failure | ||
|
|
||
| is ObservePersistentWebSocketConnectionStatusUseCase.Result.Success -> { | ||
| val statusList = withTimeoutOrNull(TIMEOUT) { | ||
| val res = result.persistentWebSocketStatusListFlow.firstOrNull() | ||
| res | ||
| } | ||
| if (statusList != null && statusList.map { it.isPersistentWebSocketEnabled }.contains(true)) Result.Success(true) | ||
| else Result.Success(false) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| sealed class Result { | ||
| data object Failure : Result() | ||
| data class Success(val shouldStartPersistentWebSocketService: Boolean) : Result() | ||
| } | ||
|
|
||
| companion object { | ||
| const val TIMEOUT = 10_000L | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
157 changes: 157 additions & 0 deletions
157
.../test/kotlin/com/wire/android/feature/ShouldStartPersistentWebSocketServiceUseCaseTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| /* | ||
| * Wire | ||
| * Copyright (C) 2024 Wire Swiss GmbH | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see http://www.gnu.org/licenses/. | ||
| */ | ||
| package com.wire.android.feature | ||
|
|
||
| import com.wire.kalium.logic.CoreLogic | ||
| import com.wire.kalium.logic.data.auth.PersistentWebSocketStatus | ||
| import com.wire.kalium.logic.data.user.UserId | ||
| import com.wire.kalium.logic.feature.user.webSocketStatus.ObservePersistentWebSocketConnectionStatusUseCase | ||
| import io.mockk.MockKAnnotations | ||
| import io.mockk.coEvery | ||
| import io.mockk.impl.annotations.MockK | ||
| import kotlinx.coroutines.flow.Flow | ||
| import kotlinx.coroutines.flow.MutableSharedFlow | ||
| import kotlinx.coroutines.flow.emptyFlow | ||
| import kotlinx.coroutines.flow.flowOf | ||
| import kotlinx.coroutines.test.advanceTimeBy | ||
| import kotlinx.coroutines.test.runTest | ||
| import org.amshove.kluent.internal.assertEquals | ||
| import org.junit.jupiter.api.Assertions.assertInstanceOf | ||
| import org.junit.jupiter.api.Test | ||
|
|
||
| class ShouldStartPersistentWebSocketServiceUseCaseTest { | ||
|
|
||
| @Test | ||
| fun givenObservePersistentWebSocketStatusReturnsSuccessAndThereAreUsersWithPersistentFlagOn_whenInvoking_shouldReturnSuccessTrue() = | ||
| runTest { | ||
| // given | ||
| val (_, useCase) = Arrangement() | ||
| .withObservePersistentWebSocketConnectionStatusSuccess(flowOf(listOf(PersistentWebSocketStatus(userId, true)))) | ||
| .arrange() | ||
| // when | ||
| val result = useCase.invoke() | ||
| // then | ||
| assertInstanceOf(ShouldStartPersistentWebSocketServiceUseCase.Result.Success::class.java, result).also { | ||
| assertEquals(true, it.shouldStartPersistentWebSocketService) | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| fun givenObservePersistentWebSocketStatusReturnsSuccessAndThereAreNoUsersWithPersistentFlagOn_whenInvoking_shouldReturnSuccessFalse() = | ||
| runTest { | ||
| // given | ||
| val (_, useCase) = Arrangement() | ||
| .withObservePersistentWebSocketConnectionStatusSuccess(flowOf(listOf(PersistentWebSocketStatus(userId, false)))) | ||
| .arrange() | ||
| // when | ||
| val result = useCase.invoke() | ||
| // then | ||
| assertInstanceOf(ShouldStartPersistentWebSocketServiceUseCase.Result.Success::class.java, result).also { | ||
| assertEquals(false, it.shouldStartPersistentWebSocketService) | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| fun givenObservePersistentWebSocketStatusReturnsSuccessAndThereAreNoUsers_whenInvoking_shouldReturnSuccessFalse() = | ||
| runTest { | ||
| // given | ||
| val (_, useCase) = Arrangement() | ||
| .withObservePersistentWebSocketConnectionStatusSuccess(flowOf(emptyList())) | ||
| .arrange() | ||
| // when | ||
| val result = useCase.invoke() | ||
| // then | ||
| assertInstanceOf(ShouldStartPersistentWebSocketServiceUseCase.Result.Success::class.java, result).also { | ||
| assertEquals(false, it.shouldStartPersistentWebSocketService) | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| fun givenObservePersistentWebSocketStatusReturnsSuccessAndTheFlowIsEmpty_whenInvoking_shouldReturnSuccessFalse() = | ||
| runTest { | ||
| // given | ||
| val (_, useCase) = Arrangement() | ||
| .withObservePersistentWebSocketConnectionStatusSuccess(emptyFlow()) | ||
| .arrange() | ||
| // when | ||
| val result = useCase.invoke() | ||
| // then | ||
| assertInstanceOf(ShouldStartPersistentWebSocketServiceUseCase.Result.Success::class.java, result).also { | ||
| assertEquals(false, it.shouldStartPersistentWebSocketService) | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| fun givenObservePersistentWebSocketStatusReturnsSuccessAndFlowTimesOut_whenInvoking_shouldReturnSuccessFalse() = | ||
| runTest { | ||
| // given | ||
| val sharedFlow = MutableSharedFlow<List<PersistentWebSocketStatus>>() // shared flow doesn't close so we can test the timeout | ||
| val (_, useCase) = Arrangement() | ||
| .withObservePersistentWebSocketConnectionStatusSuccess(sharedFlow) | ||
| .arrange() | ||
| // when | ||
| val result = useCase.invoke() | ||
| advanceTimeBy(ShouldStartPersistentWebSocketServiceUseCase.TIMEOUT + 1000L) | ||
| // then | ||
| assertInstanceOf(ShouldStartPersistentWebSocketServiceUseCase.Result.Success::class.java, result).also { | ||
| assertEquals(false, it.shouldStartPersistentWebSocketService) | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| fun givenObservePersistentWebSocketStatusReturnsFailure_whenInvoking_shouldReturnFailure() = | ||
| runTest { | ||
| // given | ||
| val (_, useCase) = Arrangement() | ||
| .withObservePersistentWebSocketConnectionStatusFailure() | ||
| .arrange() | ||
| // when | ||
| val result = useCase.invoke() | ||
| // then | ||
| assertInstanceOf(ShouldStartPersistentWebSocketServiceUseCase.Result.Failure::class.java, result) | ||
| } | ||
|
|
||
| inner class Arrangement { | ||
|
|
||
| @MockK | ||
| private lateinit var coreLogic: CoreLogic | ||
|
|
||
| val useCase by lazy { | ||
| ShouldStartPersistentWebSocketServiceUseCase(coreLogic) | ||
| } | ||
|
|
||
| init { | ||
| MockKAnnotations.init(this, relaxUnitFun = true) | ||
| } | ||
|
|
||
| fun arrange() = this to useCase | ||
|
|
||
| fun withObservePersistentWebSocketConnectionStatusSuccess(flow: Flow<List<PersistentWebSocketStatus>>) = apply { | ||
| coEvery { coreLogic.getGlobalScope().observePersistentWebSocketConnectionStatus() } returns | ||
| ObservePersistentWebSocketConnectionStatusUseCase.Result.Success(flow) | ||
| } | ||
| fun withObservePersistentWebSocketConnectionStatusFailure() = apply { | ||
| coEvery { coreLogic.getGlobalScope().observePersistentWebSocketConnectionStatus() } returns | ||
| ObservePersistentWebSocketConnectionStatusUseCase.Result.Failure.StorageFailure | ||
| } | ||
| } | ||
|
|
||
| companion object { | ||
| private val userId = UserId("userId", "domain") | ||
| } | ||
| } |