Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: original image path was used images when sharing from share extension #2604

Merged

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

app crash when sharing high-res images from the sharing extension

Causes (Optional)

the image is rescaled but the original path is used to send the image

Solutions

use the scalded image path to send

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara requested review from a team, yamilmedina, alexandreferris, borichellow, Garzas and ohassine and removed request for a team January 22, 2024 10:43
@MohamadJaara MohamadJaara enabled auto-merge (squash) January 22, 2024 10:43
Copy link
Contributor

github-actions bot commented Jan 22, 2024

Test Results

12 tests   12 ✅  0s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 2242b06.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2669 failed.

@MohamadJaara MohamadJaara merged commit e455480 into release/candidate Jan 22, 2024
9 of 10 checks passed
@MohamadJaara MohamadJaara deleted the fix/sharing-high-res-images-crashes-the-app branch January 22, 2024 12:25
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

MohamadJaara added a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants