Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2ei): set claims in OAuth flow #2623

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Pass created claims to Oauth flow.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Jan 25, 2024

Test Results

752 tests   752 ✅  6m 52s ⏱️
106 suites    0 💤
106 files      0 ❌

Results for commit 14c52c3.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 2736 failed.

@AndroidBob
Copy link
Collaborator

Build 2751 failed.

@mchenani mchenani enabled auto-merge January 25, 2024 18:25
@mchenani mchenani added this pull request to the merge queue Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (2a61529) 41.22% compared to head (14c52c3) 41.46%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2623      +/-   ##
=============================================
+ Coverage      41.22%   41.46%   +0.23%     
- Complexity      1140     1151      +11     
=============================================
  Files            367      368       +1     
  Lines          13272    13283      +11     
  Branches        1752     1749       -3     
=============================================
+ Hits            5472     5508      +36     
+ Misses          7273     7248      -25     
  Partials         527      527              
Files Coverage Δ
...essagecomposer/location/LocationPickerViewModel.kt 80.00% <100.00%> (+80.00%) ⬆️
.../android/feature/e2ei/GetE2EICertificateUseCase.kt 0.00% <0.00%> (ø)
...tlin/com/wire/android/feature/e2ei/OAuthUseCase.kt 0.00% <0.00%> (ø)
...e/messagecomposer/location/LocationPickerHelper.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c7bbef...14c52c3. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 936df80 Jan 25, 2024
14 of 15 checks passed
@mchenani mchenani deleted the feat/e2ei/set-oauth-claims branch January 25, 2024 19:16
@AndroidBob
Copy link
Collaborator

Build 2753 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants