-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2ei): respect E2EI during login and MLS client creation (WPB-5851) #2633
Merged
mchenani
merged 8 commits into
develop
from
feat/e2ei/respect-e2ei-creating-mls-client-cherry-pick
Feb 6, 2024
Merged
feat(e2ei): respect E2EI during login and MLS client creation (WPB-5851) #2633
mchenani
merged 8 commits into
develop
from
feat/e2ei/respect-e2ei-creating-mls-client-cherry-pick
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build 2776 failed. |
…oaded into feat/e2ei/respect-e2ei-creating-mls-client-cherry-pick
mchenani
changed the title
feat(e2ei): respect e2ei during login and mls client creation (WPB-5851)
feat(e2ei): respect E2EI during login and MLS client creation (WPB-5851)
Feb 6, 2024
borichellow
approved these changes
Feb 6, 2024
Build 2911 failed. |
ohassine
approved these changes
Feb 6, 2024
…oaded into feat/e2ei/respect-e2ei-creating-mls-client-cherry-pick
…mls-client-cherry-pick' into feat/e2ei/respect-e2ei-creating-mls-client-cherry-pick
APKs built during tests are available here. Scroll down to Artifacts! |
mchenani
deleted the
feat/e2ei/respect-e2ei-creating-mls-client-cherry-pick
branch
February 6, 2024 15:44
Build 2923 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
app/src/main/kotlin/com/wire/android/feature/e2ei/OAuthUseCase.kt
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Respecting E2EI state during MLS client registration and login.
Testing
Test Coverage (Optional)
WIP
How to Test
Have a team that has e2ei enabled, during login the user required to enroll certificate first.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References