Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2ei): respect E2EI during login and MLS client creation (WPB-5851) #2633

Merged

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Jan 26, 2024

TaskWPB-5851 [Android] Respect E2EI when Creating New MLS Client

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
app/src/main/kotlin/com/wire/android/feature/e2ei/OAuthUseCase.kt


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Respecting E2EI state during MLS client registration and login.

Testing

Test Coverage (Optional)

WIP

  • I have added automated test to this contribution

How to Test

Have a team that has e2ei enabled, during login the user required to enroll certificate first.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Jan 26, 2024
Copy link
Contributor

github-actions bot commented Jan 26, 2024

Test Results

795 tests  ±0   795 ✅ ±0   16m 11s ⏱️ + 1m 39s
108 suites ±0     0 💤 ±0 
108 files   ±0     0 ❌ ±0 

Results for commit 29a76b4. ± Comparison against base commit fe78d52.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator Author

Build 2776 failed.

…oaded into feat/e2ei/respect-e2ei-creating-mls-client-cherry-pick
@mchenani mchenani changed the title feat(e2ei): respect e2ei during login and mls client creation (WPB-5851) feat(e2ei): respect E2EI during login and MLS client creation (WPB-5851) Feb 6, 2024
@mchenani mchenani enabled auto-merge February 6, 2024 13:45
@AndroidBob
Copy link
Collaborator Author

Build 2911 failed.

app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved
@mchenani mchenani added this pull request to the merge queue Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 7c6148c Feb 6, 2024
12 of 13 checks passed
@mchenani mchenani deleted the feat/e2ei/respect-e2ei-creating-mls-client-cherry-pick branch February 6, 2024 15:44
@AndroidBob
Copy link
Collaborator Author

Build 2923 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants