-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: crash when answering a call (WPB-6183) #2682
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2682 +/- ##
===========================================
- Coverage 42.93% 42.82% -0.12%
===========================================
Files 408 408
Lines 13516 13516
Branches 2389 2389
===========================================
- Hits 5803 5788 -15
- Misses 7030 7050 +20
+ Partials 683 678 -5
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3041 failed. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3049 succeeded. The build produced the following APK's: |
app/src/main/kotlin/com/wire/android/ui/calling/ongoing/participantsview/ParticipantTile.kt
Outdated
Show resolved
Hide resolved
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3109 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Crash when answering a call caused by a null name.
details here:
wireapp/kalium#2481
Solutions
This PR is handling null name case by displaying a default value.
Dependencies (Optional)
Should be merged after
#2679
wireapp/kalium#2481
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.