-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2ei): remove E2EI shield and buttons if it's disabled on your team (WPB-6520) #2698
fix(e2ei): remove E2EI shield and buttons if it's disabled on your team (WPB-6520) #2698
Conversation
Build 3097 failed. |
Build 3104 failed. |
…oaded into release/fix/hide-e2ei-info-if-disabled-cherry-pick
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2698 +/- ##
===========================================
+ Coverage 42.77% 42.88% +0.10%
===========================================
Files 408 408
Lines 13516 13521 +5
Branches 2389 2389
===========================================
+ Hits 5781 5798 +17
+ Misses 7059 7047 -12
Partials 676 676
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3134 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
kalium
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
When E2EI is disabled on the user's team, all the info related to e2ei must be hidden.
Needs releases with:
Testing
Login to the user and if e2ei is disabled, shields and the get certificate on the current device screen shouldn't be visible, and if enable e2ei you should see the data.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References