Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: leaking UI context GetE2EICertificateUseCase (WPB-6648) #2713

Merged
merged 8 commits into from
Feb 16, 2024
Merged

fix: leaking UI context GetE2EICertificateUseCase (WPB-6648) #2713

merged 8 commits into from
Feb 16, 2024

Conversation

alexandreferris
Copy link
Contributor

@alexandreferris alexandreferris commented Feb 15, 2024 •
edited by github-actions bot
Loading

BugWPB-6648 [Android] GetE2EICertificateUseCase is leaking UI context

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Leaking Context from GetE2EICertificateUseCase

Causes (Optional)

Context was being passed from UI

Solutions

Inject applicationContext on ViewModel that is calling GetE2EICertificateUseCase

@alexandreferris alexandreferris self-assigned this Feb 15, 2024
@alexandreferris alexandreferris requested review from a team, typfel, yamilmedina, Garzas, ohassine and saleniuk and removed request for a team February 15, 2024 15:15
@github-actions GitHub Actions
Copy link
Contributor

Test Results

802 tests   802 ✅  13m 26s ⏱️
108 suites    0 💤
108 files      0 ❌

Results for commit 0e4dab6.

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3158 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara merged commit c27c5cf into release/candidate Feb 16, 2024
12 of 13 checks passed
@MohamadJaara MohamadJaara deleted the fix/leaking_ui_context_gete2eicertificateusecase branch February 16, 2024 11:25
@AndroidBob AndroidBob mentioned this pull request Feb 16, 2024
Merged
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3172 succeeded.

The build produced the following APK's:

mchenani added a commit that referenced this pull request Feb 26, 2024
@mchenani
Revert "fix: leaking UI context GetE2EICertificateUseCase (WPB-6648) (#…
55b4236 
…2713)"

This reverts commit c27c5cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@typfel typfel Awaiting requested review from typfel typfel was automatically assigned from wireapp/android

@yamilmedina yamilmedina Awaiting requested review from yamilmedina yamilmedina was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

Assignees

@alexandreferris alexandreferris

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandreferris @AndroidBob @MohamadJaara @saleniuk