Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show connection request with unavailable name [WPB-6247] #2716

Merged

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Feb 16, 2024

BugWPB-6247 [Android] Incoming connection request from offline backend not displayed when backend is available again


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Connection requests with incomplete user data shows empty text in user name

Solutions

When user has incomplete data show name not available username text

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
before after

@AndroidBob
Copy link
Collaborator

Build 3167 succeeded.

The build produced the following APK's:

@Garzas Garzas enabled auto-merge (squash) February 16, 2024 11:17
Copy link
Contributor

github-actions bot commented Feb 16, 2024

Test Results

12 tests   12 ✅  0s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 727843d.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 3177 failed.

@AndroidBob
Copy link
Collaborator

Build 3183 failed.

@Garzas Garzas merged commit 1a2034e into release/candidate Feb 16, 2024
11 of 12 checks passed
@Garzas Garzas deleted the fix/show-connection-request-with-unavailable-name branch February 16, 2024 15:09
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3184 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants