Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Technolinator config for dependencytrack, setting the correct java version (SEC-598) #2720

Merged
merged 7 commits into from
Mar 28, 2024

Conversation

emil-wire
Copy link
Collaborator

What's new in this PR?

Issues

CDXgen was not able to get the correct dependency tree for kalium previously, because it used java21 internally. This config sets the java version to 17 and enables cdxgen to create a dependency tree and push it to dependency track.

How to Test

No need, this change is transparent for devs and only pertains to security tooling and should have no visible effect at all.

@emil-wire emil-wire marked this pull request as draft February 20, 2024 09:25
Copy link
Contributor

github-actions bot commented Feb 20, 2024

Test Results

878 tests  ±0   878 ✅ ±0   11m 41s ⏱️ - 1m 3s
120 suites ±0     0 💤 ±0 
120 files   ±0     0 ❌ ±0 

Results for commit 0225002. ± Comparison against base commit 323f244.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3230 succeeded.

The build produced the following APK's:

excludes kalium directory because it's not necessary to scan it
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@emil-wire emil-wire changed the title Add Technolinator config for dependencytrack, setting the correct java version (SEC-598) chore (ci): Add Technolinator config for dependencytrack, setting the correct java version (SEC-598) Mar 15, 2024
@emil-wire emil-wire changed the title chore (ci): Add Technolinator config for dependencytrack, setting the correct java version (SEC-598) chore: Add Technolinator config for dependencytrack, setting the correct java version (SEC-598) Mar 15, 2024
@emil-wire emil-wire changed the title chore: Add Technolinator config for dependencytrack, setting the correct java version (SEC-598) chore: Add Technolinator config for dependencytrack, setting the correct java version [SEC-598] Mar 15, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@MohamadJaara MohamadJaara changed the title chore: Add Technolinator config for dependencytrack, setting the correct java version [SEC-598] chore: Add Technolinator config for dependencytrack, setting the correct java version Mar 28, 2024
@MohamadJaara MohamadJaara changed the title chore: Add Technolinator config for dependencytrack, setting the correct java version chore: Add Technolinator config for dependencytrack, setting the correct java version [SEC-598] Mar 28, 2024
@yamilmedina yamilmedina changed the title chore: Add Technolinator config for dependencytrack, setting the correct java version [SEC-598] chore: Add Technolinator config for dependencytrack, setting the correct java version (SEC-598) Mar 28, 2024
@yamilmedina yamilmedina changed the title chore: Add Technolinator config for dependencytrack, setting the correct java version (SEC-598) chore: add Technolinator config for dependencytrack, setting the correct java version (SEC-598) Mar 28, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@emil-wire emil-wire marked this pull request as ready for review March 28, 2024 15:56
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3863 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina enabled auto-merge March 28, 2024 16:55
@yamilmedina yamilmedina requested review from yamilmedina, a team, vitorhugods, mchenani, Garzas and ohassine and removed request for a team March 28, 2024 16:56
@yamilmedina yamilmedina added this pull request to the merge queue Mar 28, 2024
Merged via the queue into wireapp:develop with commit 8dbc70d Mar 28, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants