-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: some end points are not routed through the proxy server 4.6 #2723
Conversation
) (cherry picked from commit fe77f90)
Build 3241 failed. |
Test Results809 tests 809 ✅ 20m 7s ⏱️ Results for commit a5ec2da. ♻️ This comment has been updated with latest results. |
Build 3358 failed. |
Build 3394 failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, just a tiny line break too many.
Build 3398 failed. |
60d2c97
to
a5ec2da
Compare
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3403 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
some end points are not routed through the proxy server mainly the api version
Solutions
refactore the code so every thing is under the unauthenticated container and make sure is does have the proxy info passed correctly
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
run the app connet to wire server via socks proxy (message me if you need the setup) and in the network inspection only proxy link is used
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.