Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some end points are not routed through the proxy server 4.6 #2723

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

MohamadJaara
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

some end points are not routed through the proxy server mainly the api version

Solutions

refactore the code so every thing is under the unauthenticated container and make sure is does have the proxy info passed correctly

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

run the app connet to wire server via socks proxy (message me if you need the setup) and in the network inspection only proxy link is used

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@MohamadJaara MohamadJaara changed the title fix: some end points are not routed through the proxy server v4.5 (#… fix: some end points are not routed through the proxy server 4.6 Feb 21, 2024
@AndroidBob
Copy link
Collaborator

Build 3241 failed.

Copy link
Contributor

github-actions bot commented Feb 21, 2024

Test Results

809 tests   809 ✅  20m 7s ⏱️
109 suites    0 💤
109 files      0 ❌

Results for commit a5ec2da.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 3358 failed.

@AndroidBob
Copy link
Collaborator

Build 3394 failed.

Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just a tiny line break too many.

@AndroidBob
Copy link
Collaborator

Build 3398 failed.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3403 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara merged commit 1d39d4a into release/candidate Feb 29, 2024
15 checks passed
@MohamadJaara MohamadJaara deleted the fix/proxy-issues-4.6 branch February 29, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants