Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): loading e2ei state during the app initialisation #2755

Conversation

AndroidBob
Copy link
Collaborator

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Loading the e2ei state if it's blocking the client registration during login when reopening the app as a blocking value.

Issues

The value of e2ei state was not loaded in blocking state, causes incorrect behaviour.

How to Test

Login with an account that has E2EI enabled on their team, then while getting the E2EI certificate, kill and re open the app; the app must open the enrol certificate screen again to continue from there.

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 43.15%. Comparing base (1875400) to head (3368085).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2755      +/-   ##
===========================================
- Coverage    43.18%   43.15%   -0.04%     
===========================================
  Files          409      409              
  Lines        13584    13580       -4     
  Branches      2398     2399       +1     
===========================================
- Hits          5866     5860       -6     
- Misses        7031     7033       +2     
  Partials       687      687              
Files Coverage Δ
...otlin/com/wire/android/ui/WireActivityViewModel.kt 68.14% <57.14%> (-1.30%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1875400...3368085. Read the comment docs.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Test Results

827 tests  ±0   827 ✅ ±0   8m 16s ⏱️ - 6m 22s
115 suites ±0     0 💤 ±0 
115 files   ±0     0 ❌ ±0 

Results for commit 3368085. ± Comparison against base commit 1875400.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3416 succeeded.

The build produced the following APK's:

@MohamadJaara MohamadJaara enabled auto-merge March 4, 2024 12:46
@MohamadJaara MohamadJaara added this pull request to the merge queue Mar 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit f54e896 Mar 4, 2024
13 of 14 checks passed
@MohamadJaara MohamadJaara deleted the release/fix/getting-e2ei-state-during-registration-cherry-pick branch March 4, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants