-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2ei): loading e2ei state during the app initialisation #2755
fix(e2ei): loading e2ei state during the app initialisation #2755
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2755 +/- ##
===========================================
- Coverage 43.18% 43.15% -0.04%
===========================================
Files 409 409
Lines 13584 13580 -4
Branches 2398 2399 +1
===========================================
- Hits 5866 5860 -6
- Misses 7031 7033 +2
Partials 687 687
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3416 succeeded. The build produced the following APK's: |
…istration-cherry-pick
APKs built during tests are available here. Scroll down to Artifacts! |
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Loading the e2ei state if it's blocking the client registration during login when reopening the app as a blocking value.
Issues
The value of e2ei state was not loaded in blocking state, causes incorrect behaviour.
How to Test
Login with an account that has E2EI enabled on their team, then while getting the E2EI certificate, kill and re open the app; the app must open the enrol certificate screen again to continue from there.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References