Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle guest 1:1 conversation when legal hold requested [WPB-5937] #2763

Merged
merged 10 commits into from
Mar 12, 2024

Conversation

saleniuk
Copy link
Contributor

@saleniuk saleniuk commented Mar 4, 2024

StoryWPB-5937 [Android] Handling already connected guests in 1:1 conversations


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When a user becomes under legal hold then their 1:1 conversations with guests should be disabled due to one side not having legal hold consent.

Solutions

Check if the 1:1 conversation's legal hold status is ENABLED or DEGRADED (it means that one of members got the legal hold request and another hasn't consent to legal hold). If so, then disable messsage composer and all retry failed message buttons.
Also, fixed message composer previews.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Wile being logged in as a guest, have a 1:1 conversation with some team member and request legal hold for that team member - the conversation should be degraded and sending messages should be disabled.

Attachments (Optional)

Screen.Recording.2024-03-04.at.17.44.43.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Test Results

857 tests  ±0   857 ✅ ±0   10m 28s ⏱️ -37s
116 suites ±0     0 💤 ±0 
116 files   ±0     0 ❌ ±0 

Results for commit c40ed80. ± Comparison against base commit b044154.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 43.43%. Comparing base (b044154) to head (c40ed80).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2763   +/-   ##
========================================
  Coverage    43.43%   43.43%           
========================================
  Files          411      411           
  Lines        13863    13867    +4     
  Branches      2517     2517           
========================================
+ Hits          6021     6023    +2     
- Misses        7134     7137    +3     
+ Partials       708      707    -1     
Files Coverage Δ
.../wire/android/ui/home/conversations/MessageItem.kt 0.00% <ø> (ø)
...android/ui/home/conversations/SystemMessageItem.kt 0.00% <ø> (ø)
...otlin/com/wire/android/util/ui/StyledStringUtil.kt 0.00% <0.00%> (ø)
...e/conversations/typing/TypingIndicatorViewModel.kt 85.71% <75.00%> (-14.29%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b044154...c40ed80. Read the comment docs.

@saleniuk saleniuk requested review from a team, yamilmedina, borichellow, vitorhugods, mchenani and e-lisa and removed request for a team March 4, 2024 17:41
Copy link
Contributor

github-actions bot commented Mar 4, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3470 succeeded.

The build produced the following APK's:

@saleniuk saleniuk requested review from a team and ohassine and removed request for e-lisa and a team March 5, 2024 09:16
…ndle-1on1s-with-guests

# Conflicts:
#	kalium
Copy link
Contributor

@alexandreferris alexandreferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I just have one tiny nitpick, more of a question if the writing makes sense

app/src/main/res/values/strings.xml Show resolved Hide resolved
@saleniuk saleniuk enabled auto-merge March 12, 2024 17:09
@saleniuk saleniuk added this pull request to the merge queue Mar 12, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3553 succeeded.

The build produced the following APK's:

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2024
@yamilmedina yamilmedina enabled auto-merge March 12, 2024 18:23
@yamilmedina yamilmedina added this pull request to the merge queue Mar 12, 2024
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 724816c Mar 12, 2024
14 of 15 checks passed
@yamilmedina yamilmedina deleted the feat/legal-hold-handle-1on1s-with-guests branch March 12, 2024 19:06
@AndroidBob
Copy link
Collaborator

Build 3567 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants