-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle guest 1:1 conversation when legal hold requested [WPB-5937] #2763
feat: handle guest 1:1 conversation when legal hold requested [WPB-5937] #2763
Conversation
…ndle-1on1s-with-guests
…ndle-1on1s-with-guests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2763 +/- ##
========================================
Coverage 43.43% 43.43%
========================================
Files 411 411
Lines 13863 13867 +4
Branches 2517 2517
========================================
+ Hits 6021 6023 +2
- Misses 7134 7137 +3
+ Partials 708 707 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3470 succeeded. The build produced the following APK's: |
…ndle-1on1s-with-guests # Conflicts: # kalium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! I just have one tiny nitpick, more of a question if the writing makes sense
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3553 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3567 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When a user becomes under legal hold then their 1:1 conversations with guests should be disabled due to one side not having legal hold consent.
Solutions
Check if the 1:1 conversation's legal hold status is
ENABLED
orDEGRADED
(it means that one of members got the legal hold request and another hasn't consent to legal hold). If so, then disable messsage composer and all retry failed message buttons.Also, fixed message composer previews.
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Wile being logged in as a guest, have a 1:1 conversation with some team member and request legal hold for that team member - the conversation should be degraded and sending messages should be disabled.
Attachments (Optional)
Screen.Recording.2024-03-04.at.17.44.43.mov
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.