Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e webview close [WPB-6788] #2764

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Mar 4, 2024

BugWPB-6788 [Android] Fix crash on opening the browser for E2EI IDP authorization

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

viewModel.getCertificate(isNewClient) was not called from LaunchedEffect, which triggered again on recompose opening webview

Causes (Optional)

E2E webview opened from dialog was closed after second

Solutions

Add LaunchedEffect

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.15%. Comparing base (42d82dd) to head (56865fe).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2764      +/-   ##
===========================================
+ Coverage    43.03%   43.15%   +0.11%     
===========================================
  Files          409      409              
  Lines        13579    13580       +1     
  Branches      2399     2400       +1     
===========================================
+ Hits          5844     5860      +16     
+ Misses        7055     7033      -22     
- Partials       680      687       +7     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d82dd...56865fe. Read the comment docs.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

Test Results

827 tests  ±0   827 ✅ ±0   14m 3s ⏱️ + 5m 26s
115 suites ±0     0 💤 ±0 
115 files   ±0     0 ❌ ±0 

Results for commit 56865fe. ± Comparison against base commit 42d82dd.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 4, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3474 succeeded.

The build produced the following APK's:

Copy link
Contributor

@saleniuk saleniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the kalium conflict

@Garzas Garzas requested a review from saleniuk March 7, 2024 08:53
Copy link
Contributor

github-actions bot commented Mar 7, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3495 succeeded.

The build produced the following APK's:

@Garzas Garzas added this pull request to the merge queue Mar 7, 2024
Merged via the queue into develop with commit c816a0b Mar 7, 2024
15 checks passed
@Garzas Garzas deleted the fix/e2e-webview-close-cherry-pick branch March 7, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants