-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: e2e webview close [WPB-6788] #2764
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2764 +/- ##
===========================================
+ Coverage 43.03% 43.15% +0.11%
===========================================
Files 409 409
Lines 13579 13580 +1
Branches 2399 2400 +1
===========================================
+ Hits 5844 5860 +16
+ Misses 7055 7033 -22
- Partials 680 687 +7 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3474 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the kalium conflict
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3495 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
kalium
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
viewModel.getCertificate(isNewClient) was not called from LaunchedEffect, which triggered again on recompose opening webview
Causes (Optional)
E2E webview opened from dialog was closed after second
Solutions
Add LaunchedEffect