-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade kotlin to 1.9.23 #2767
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2767 +/- ##
===========================================
- Coverage 43.62% 43.20% -0.43%
===========================================
Files 422 409 -13
Lines 14087 13555 -532
Branches 2543 2359 -184
===========================================
- Hits 6146 5856 -290
+ Misses 7225 7015 -210
+ Partials 716 684 -32
... and 94 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3481 failed. |
Build 3492 succeeded. The build produced the following APK's: |
Also update surrounding dependencies to match
31432f8
to
46b6560
Compare
Build 3904 failed. |
Build 3905 failed. |
Build 3906 failed. |
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2767 +/- ##
===========================================
+ Coverage 43.62% 43.75% +0.12%
===========================================
Files 422 422
Lines 14087 14057 -30
Branches 2543 2501 -42
===========================================
+ Hits 6146 6150 +4
+ Misses 7225 7189 -36
- Partials 716 718 +2
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3908 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Other than Kotlin being a bit behind (1.9.0, considering 1.9.22 is available), some other libraries are lagging behind.
Kotlin 2.0 is around the corner and we should try to keep up to catch breaking changes and deal with them earlier.
Solutions
Update as much as we can and reasonably can on
develop
before getting too close to a4.7.0
release. So when we finally make the jump to2.0
(whenever that might be), it won't be as much of a hassle.Important
No Compose/Material updates to avoid breaking UI changes.
The only change was the compose compiler, to keep it compatible with Kotlin 1.9.22. The compiler itself does not change UI looks.
Testing
Ran tests and the Android app locally. Everything alright.
Dependencies
This PR depends on:
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.