Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: explicitly restrict the app to be installed internally #2769

Merged
merged 4 commits into from
Mar 12, 2024
Merged

chore: explicitly restrict the app to be installed internally #2769

merged 4 commits into from
Mar 12, 2024

Conversation

AndroidBob
Copy link
Collaborator

Cherry pick from the original PR:

⚠️ Conflicts during cherry-pick:
kalium

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

explicitly restrict the app to be installed internally
this is already the default behaviour and this just makes it explicitly defined

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Mar 6, 2024
@AndroidBob
Copy link
Collaborator Author

Build 3487 failed.

ohassine added 2 commits March 12, 2024 17:54
@ohassine
chore: update kalium reference
091b701
@ohassine
Merge remote-tracking branch 'origin/develop' into chore/explicitly--…
25a8c9a 
…restrice-install-locatopn-to-internal-cherry-pick

# Conflicts:
#	kalium
@ohassine ohassine enabled auto-merge March 12, 2024 16:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024 •
edited
Loading

Test Results

857 tests  ±0   857 ✅ ±0   20m 22s ⏱️ + 6m 27s
116 suites ±0     0 💤 ±0 
116 files   ±0     0 ❌ ±0 

Results for commit f4964a8. ± Comparison against base commit 724816c.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator Author

Build 3555 failed.

@ohassine
Merge remote-tracking branch 'origin/develop' into chore/explicitly--…
f4964a8 
…restrice-install-locatopn-to-internal-cherry-pick

# Conflicts:
#	kalium
@ohassine ohassine added this pull request to the merge queue Mar 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3572 failed.

Merged via the queue into develop with commit bf7794e Mar 12, 2024
14 of 15 checks passed
@ohassine ohassine deleted the chore/explicitly--restrice-install-locatopn-to-internal-cherry-pick branch March 12, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohassine ohassine ohassine approved these changes

@MohamadJaara MohamadJaara MohamadJaara approved these changes

Assignees

@MohamadJaara MohamadJaara

Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndroidBob @MohamadJaara @ohassine