Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: persistent ws not reflected in UI (WPB-7020) #2770

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Mar 6, 2024

BugWPB-7020 [Android] Websocket switch does not turn to ON state anymore (but enabling websocket works)


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We had a regression on the websocket button config in network settings.
Even the ws was enabled, the button was always off.

Testing

Manually tested

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Mar 6, 2024
@yamilmedina yamilmedina requested review from MohamadJaara, a team, typfel, alexandreferris, mchenani and Garzas and removed request for a team March 6, 2024 13:05
@yamilmedina yamilmedina enabled auto-merge (squash) March 6, 2024 13:07
@yamilmedina yamilmedina merged commit 3dae65c into release/candidate Mar 6, 2024
8 of 9 checks passed
@yamilmedina yamilmedina deleted the fix/ws-not-reflected-ui branch March 6, 2024 13:29
Copy link
Contributor

github-actions bot commented Mar 6, 2024

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3489 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants