Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: periodic checks for ws service to start if necessary (WPB-6343) #2773

Merged
merged 12 commits into from
Mar 14, 2024
Merged

fix: periodic checks for ws service to start if necessary (WPB-6343) #2773

merged 12 commits into from
Mar 14, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Mar 7, 2024 •
edited by github-actions bot
Loading

BugWPB-6343 [Android] Incoming calls not shown on column-1 builds

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

In some devices there is the case that the persistent websocket connection (foreground service) is being killed by the os.

Causes (Optional)

Doze mode, optimization from some manufacter.

Solutions

Schedule a periodic check (24 hours) to see if we need to restart the ws service.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Attachments (Optional)

Dry-run of the worker running every 15 min. for testing purposes

Screenshot 2024-03-11 at 11 40 39

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Mar 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

Test Results

812 tests   812 ✅  11m 19s ⏱️
110 suites    0 💤
110 files      0 ❌

Results for commit 8e85e61.

♻️ This comment has been updated with latest results.

@MohamadJaara MohamadJaara dismissed their stale review March 11, 2024 08:52

i got it wrong

@yamilmedina yamilmedina marked this pull request as ready for review March 11, 2024 13:02
@yamilmedina yamilmedina requested review from a team, alexandreferris, mchenani, Garzas, ohassine and saleniuk and removed request for a team March 11, 2024 13:03
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3532 succeeded.

The build produced the following APK's:

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3549 succeeded.

The build produced the following APK's:

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3592 succeeded.

The build produced the following APK's:

@AndroidBob
Copy link
Collaborator

Build 3594 succeeded.

The build produced the following APK's:

@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

borichellow
borichellow approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small style suggestion :)

app/src/main/kotlin/com/wire/android/feature/StartPersistentWebsocketIfNecessaryUseCase.kt Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3602 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina enabled auto-merge (squash) March 14, 2024 15:02
@yamilmedina yamilmedina merged commit ce5094b into release/candidate Mar 14, 2024
10 of 11 checks passed
@yamilmedina yamilmedina deleted the fix/relaunch-periodic-wss branch March 14, 2024 15:19
@AndroidBob AndroidBob mentioned this pull request Mar 14, 2024
Merged
7 tasks
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3603 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorhugods vitorhugods vitorhugods left review comments

@MohamadJaara MohamadJaara MohamadJaara left review comments

@saleniuk saleniuk saleniuk approved these changes

@borichellow borichellow borichellow approved these changes

@alexandreferris alexandreferris Awaiting requested review from alexandreferris alexandreferris was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

@ohassine ohassine Awaiting requested review from ohassine ohassine was automatically assigned from wireapp/android

Assignees

@yamilmedina yamilmedina

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yamilmedina @AndroidBob @borichellow @MohamadJaara @vitorhugods @saleniuk