fix: legal hold dialogs content [WPB-6469]

[saleniuk]

WPB-6469 The LH member when sending the message to Normal User(Not under LH) showing Normal Member as Under the Legal Hold.

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

On dialog about 1:1 conversation being under legal hold, the name of the conversation suggests that the user is under legal hold. This dialog takes the conversation name, so for 1:1 conversations it's the other member name, but if I am under legal hold then it can falsely state that "John Doe is under legal hold" when John Doe actually isn't, it's just the conversation between me and John Doe because I am under legal hold.

Solutions

Adjust the dialog to be exactly like on designs with title without the exact conversation name but more generic one.
Change the order of buttons as well to match the designs.

Attachments (Optional)

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.43%. Comparing base (eba05a8) to head (4bf508b).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2775   +/-   ##
========================================
  Coverage    43.43%   43.43%           
========================================
  Files          411      411           
  Lines        13863    13863           
  Branches      2517     2517           
========================================
  Hits          6021     6021           
+ Misses        7135     7134    -1     
- Partials       707      708    +1     

see 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba05a8...4bf508b. Read the comment docs.

[github-actions]

Test Results

857 tests  ±0   857 ✅ ±0   16m 16s ⏱️ + 7m 31s
116 suites ±0     0 💤 ±0 
116 files   ±0     0 ❌ ±0 

Results for commit 4bf508b. ± Comparison against base commit eba05a8.

♻️ This comment has been updated with latest results.

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[AndroidBob]

Build 3508 succeeded.

The build produced the following APK's:

• com.wire.android-v4.7.0(9094488)(9094488)-staging-compat.apk

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[AndroidBob]

Build 3550 succeeded.

The build produced the following APK's:

• com.wire.android-v4.7.0(9129274)(9129274)-staging-compat.apk