Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create Group protocol not editable anymore [WPB-7109] #2791

Merged

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Mar 14, 2024

BugWPB-7109 Different behaviour to identify a MLS conversation on Android and Web

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:

What's new in this PR?

Issues

User should not be able to change a protocol during the creating a group.
Group protocol is the default one!

Causes (Optional)

Requirements changed

Solutions

Change it.

Attachments (Optional)

<img width=377 alt=Screenshot 2024-03-14 at 12 21 04 src=https://github.com/wireapp/wire-android/assets/6539347/97d4138f-78e3-455e-ad0c-b9c44a292daa>

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.53%. Comparing base (e1581cc) to head (1c9d0d3).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2791      +/-   ##
===========================================
+ Coverage    43.37%   43.53%   +0.15%     
===========================================
  Files          413      413              
  Lines        13903    13900       -3     
  Branches      2515     2516       +1     
===========================================
+ Hits          6031     6051      +20     
+ Misses        7167     7137      -30     
- Partials       705      712       +7     
Files Coverage Δ
...i/home/newconversation/NewConversationViewModel.kt 55.44% <100.00%> (-1.70%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1581cc...1c9d0d3. Read the comment docs.

Copy link
Contributor

github-actions bot commented Mar 14, 2024

Test Results

860 tests  ±0   860 ✅ ±0   12m 2s ⏱️ + 2m 48s
117 suites ±0     0 💤 ±0 
117 files   ±0     0 ❌ ±0 

Results for commit 1c9d0d3. ± Comparison against base commit e1581cc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3597 succeeded.

The build produced the following APK's:

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator Author

Build 3621 succeeded.

The build produced the following APK's:

@saleniuk saleniuk added this pull request to the merge queue Mar 15, 2024
Merged via the queue into develop with commit df1c124 Mar 15, 2024
14 checks passed
@saleniuk saleniuk deleted the fix/creat_group_protocol_not_editable_anymore-cherry-pick branch March 15, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants