-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Create Group protocol not editable anymore [WPB-7109] #2791
fix: Create Group protocol not editable anymore [WPB-7109] #2791
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2791 +/- ##
===========================================
+ Coverage 43.37% 43.53% +0.15%
===========================================
Files 413 413
Lines 13903 13900 -3
Branches 2515 2516 +1
===========================================
+ Hits 6031 6051 +20
+ Misses 7167 7137 -30
- Partials 705 712 +7
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3597 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3621 succeeded. The build produced the following APK's: |
Cherry pick from the original PR:
What's new in this PR?
Issues
User should not be able to change a protocol during the creating a group.
Group protocol is the default one!
Causes (Optional)
Requirements changed
Solutions
Change it.
Attachments (Optional)
<img width=377 alt=Screenshot 2024-03-14 at 12 21 04 src=https://github.com/wireapp/wire-android/assets/6539347/97d4138f-78e3-455e-ad0c-b9c44a292daa>