Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stay in call screen after back button from fullscreen [WPB-640] #2795

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Mar 17, 2024

StoryWPB-640 When video is maximized and user taps on back button, video should minimise


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When user clicks back button on full screen video in call then it closes entire call screen instead stay in it.

Solutions

Add BackHandler in full screen tile to get back to call screen

@Garzas Garzas requested review from alexandreferris, ohassine and a team March 17, 2024 13:32
@Garzas Garzas self-assigned this Mar 17, 2024
@Garzas Garzas requested review from borichellow, MohamadJaara and mchenani and removed request for a team March 17, 2024 13:32
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.53%. Comparing base (2ff2e04) to head (64ada69).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2795       +/-   ##
============================================
+ Coverage         0   43.53%   +43.53%     
============================================
  Files            0      413      +413     
  Lines            0    13903    +13903     
  Branches         0     2516     +2516     
============================================
+ Hits             0     6052     +6052     
- Misses           0     7139     +7139     
- Partials         0      712      +712     
Files Coverage Δ
...id/ui/calling/ongoing/fullscreen/FullScreenTile.kt 0.00% <ø> (ø)

... and 412 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff2e04...64ada69. Read the comment docs.

Copy link
Contributor

Test Results

860 tests  ±0   860 ✅ ±0   7m 36s ⏱️ - 4m 51s
117 suites ±0     0 💤 ±0 
117 files   ±0     0 ❌ ±0 

Results for commit 64ada69. ± Comparison against base commit 2ff2e04.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3638 succeeded.

The build produced the following APK's:

@Garzas Garzas added this pull request to the merge queue Mar 19, 2024
Merged via the queue into develop with commit 334db7b Mar 19, 2024
21 checks passed
@Garzas Garzas deleted the fix/call-fullscreen-back-button branch March 19, 2024 07:52
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants