Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnecessarily calls to updateVideoState function (WPB-6747) #2798

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Mar 18, 2024

BugWPB-6747 Calling `wcall_set_video_send_state` unnecessarily


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

unnecessarily calls to onClearSelfUserVideoPreview() function .

Causes (Optional)

Every time the participant object changes, the screen is recomposing and tries to call onClearSelfUserVideoPreview() as the camera is turned off.
This would cause many calls to wcall_set_video_send_state of AVS with Stopped state.

Solutions

Use a boolean value that will be remembered if the screen recompose to ensure a single call to onClearSelfUserVideoPreview()

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.57%. Comparing base (2ff2e04) to head (1a810e6).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2798       +/-   ##
============================================
+ Coverage         0   43.57%   +43.57%     
============================================
  Files            0      413      +413     
  Lines            0    13903    +13903     
  Branches         0     2516     +2516     
============================================
+ Hits             0     6058     +6058     
- Misses           0     7132     +7132     
- Partials         0      713      +713     

see 413 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff2e04...1a810e6. Read the comment docs.

Copy link
Contributor

Test Results

860 tests  ±0   860 ✅ ±0   12m 53s ⏱️ +26s
117 suites ±0     0 💤 ±0 
117 files   ±0     0 ❌ ±0 

Results for commit 1a810e6. ± Comparison against base commit 2ff2e04.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3644 succeeded.

The build produced the following APK's:

MohamadJaara
MohamadJaara previously approved these changes Mar 19, 2024
@MohamadJaara MohamadJaara dismissed their stale review March 19, 2024 07:19

i got a question

@ohassine ohassine added this pull request to the merge queue Mar 25, 2024
Merged via the queue into develop with commit 0f311bd Mar 25, 2024
14 checks passed
@ohassine ohassine deleted the unnecessarily_calls_of_update_video_state branch March 25, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants