-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unnecessarily calls to updateVideoState function (WPB-6747) #2798
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2798 +/- ##
============================================
+ Coverage 0 43.57% +43.57%
============================================
Files 0 413 +413
Lines 0 13903 +13903
Branches 0 2516 +2516
============================================
+ Hits 0 6058 +6058
- Misses 0 7132 +7132
- Partials 0 713 +713 see 413 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 3644 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
unnecessarily calls to
onClearSelfUserVideoPreview()
function .Causes (Optional)
Every time the participant object changes, the screen is recomposing and tries to call
onClearSelfUserVideoPreview()
as the camera is turned off.This would cause many calls to
wcall_set_video_send_state
of AVS with Stopped state.Solutions
Use a boolean value that will be remembered if the screen recompose to ensure a single call to
onClearSelfUserVideoPreview()
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.