fix: Calling video not streamed when enabling camera on preview screen (WPB-7114) #2801

ohassine · 2024-03-20T13:21:36Z

WPB-7114 [Android] When video is enabled on precall screen, video is not streamed during 1:1 and group call

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Calling video not streamed when enabling camera on preview screen of an incoming call.

Causes (Optional)

TLDR: A race condition.
Establishing an incoming calls takes some times an important time, causing to call the function of video stream before the call get established.

Solutions

I moved the logic of sending video feed to OngoingCallViewModel, this way we are sure setVideoSendState will be called only when the call get established.

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Start a call to an android device.
On Android enable your camera and accept the call
You should still see your camera on, and the other person see your video feed.

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…streamed # Conflicts: # kalium

github-actions · 2024-03-20T13:22:11Z

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
18b7699e312bedf08a441433e25d96fb37dc920f	d35b34badde0f7e46c3434602b5e6a2bd4dcf1f7

Is this intentional?

github-actions · 2024-03-20T13:25:03Z

Test Results

878 tests ±0 878 ✅ ±0 15m 43s ⏱️ + 5m 46s
118 suites ±0 0 💤 ±0
118 files ±0 0 ❌ ±0

Results for commit ceb5b02. ± Comparison against base commit 17f1c2a.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.

com.wire.android.ui.calling.SharedCallingViewModelTest ‑ given a video call, when stopping video, then clear Video Preview and turn off speaker()
com.wire.android.ui.calling.SharedCallingViewModelTest ‑ given an active call, when clearVideoPreview is called, then update video state to STOPPED()
com.wire.android.ui.calling.SharedCallingViewModelTest ‑ given an active call, when setVideoPreview is called, then set the video preview and update video state to STARTED()
com.wire.android.ui.calling.SharedCallingViewModelTest ‑ given an audio call, when stopVideo is invoked, then do not do anything()

com.wire.android.ui.calling.OngoingCallViewModelTest ‑ givenAnOngoingCall_WhenTurningOffCamera_ThenSetVideoSendStateToStopped()
com.wire.android.ui.calling.OngoingCallViewModelTest ‑ givenAnOngoingCall_WhenTurningOnCamera_ThenSetVideoSendStateToStarted()
com.wire.android.ui.calling.SharedCallingViewModelTest ‑ given a call, when clearVideoPreview is called, then clear view()
com.wire.android.ui.calling.SharedCallingViewModelTest ‑ given a call, when setVideoPreview is called, then set the video preview()

♻️ This comment has been updated with latest results.

github-actions · 2024-03-20T13:29:05Z

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
18b7699e312bedf08a441433e25d96fb37dc920f	d35b34badde0f7e46c3434602b5e6a2bd4dcf1f7

Is this intentional?

AndroidBob · 2024-03-20T13:42:05Z

Build 3661 failed.

AndroidBob · 2024-03-20T13:55:51Z

Build 3662 failed.

AndroidBob · 2024-03-20T14:06:29Z

Build 3663 failed.

github-actions · 2024-03-20T14:08:19Z

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
18b7699e312bedf08a441433e25d96fb37dc920f	4fc22b91cf55bda1d512ad37d287e5418a355d12

Is this intentional?

AndroidBob · 2024-03-20T14:52:24Z

Build 3664 failed.

github-actions · 2024-03-20T14:59:52Z

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
18b7699e312bedf08a441433e25d96fb37dc920f	4fc22b91cf55bda1d512ad37d287e5418a355d12

Is this intentional?

codecov · 2024-03-20T15:25:23Z

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 43.61%. Comparing base (17f1c2a) to head (ceb5b02).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2801      +/-   ##
===========================================
+ Coverage    43.45%   43.61%   +0.16%     
===========================================
  Files          418      418              
  Lines        14000    14007       +7     
  Branches      2532     2536       +4     
===========================================
+ Hits          6083     6109      +26     
+ Misses        7210     7181      -29     
- Partials       707      717      +10

Files	Coverage Δ
.../wire/android/ui/calling/SharedCallingViewModel.kt	`63.57% <60.00%> (-1.26%)`	⬇️
...android/ui/calling/ongoing/OngoingCallViewModel.kt	`70.00% <66.66%> (-1.43%)`	⬇️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f1c2a...ceb5b02. Read the comment docs.

github-actions · 2024-03-20T15:38:01Z

APKs built during tests are available here. Scroll down to Artifacts!

AndroidBob · 2024-03-20T15:51:24Z

Build 3667 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(9198046)(9198046)-staging-compat.apk

MohamadJaara

Please remember to cherry-pick this change into RC

…streamed # Conflicts: # kalium

github-actions · 2024-03-25T09:52:13Z

APKs built during tests are available here. Scroll down to Artifacts!

…n (WPB-7114) (#2801)

AndroidBob · 2024-03-25T10:42:02Z

Build 3719 succeeded.

The build produced the following APK's:

com.wire.android-v4.7.0(9239319)(9239319)-staging-compat.apk

ohassine added 3 commits March 20, 2024 14:10

fix: calling video not streamed when enabling camera in preview screen

5b9046a

chore: kalium reference

64bcdd5

Merge remote-tracking branch 'origin/develop' into calling_video_not_…

55bf9a6

…streamed # Conflicts: # kalium

pull-request-size bot added the size/S label Mar 20, 2024

github-actions bot assigned ohassine Mar 20, 2024

ohassine mentioned this pull request Mar 20, 2024

feat: add SetVideoSendStateUseCase (WPB-7114) wireapp/kalium#2670

Merged

8 tasks

chore: detekt

12de6d1

ohassine requested review from a team, typfel, yamilmedina, mchenani, Garzas and e-lisa and removed request for a team March 20, 2024 13:29

ohassine removed the request for review from e-lisa March 20, 2024 13:29

chore: update kalium reference

f4ce537

chore: empty commit

c625a8f

chore: update kalium reference

be10376

chore: unit test

30f020b

ohassine requested review from alexandreferris and MohamadJaara March 20, 2024 15:01

alexandreferris approved these changes Mar 20, 2024

View reviewed changes

MohamadJaara approved these changes Mar 21, 2024

View reviewed changes

ohassine added 2 commits March 25, 2024 10:05

chore: update kalium reference

5499559

Merge remote-tracking branch 'origin/develop' into calling_video_not_…

d28dff7

…streamed # Conflicts: # kalium

ohassine enabled auto-merge March 25, 2024 09:06

Merge remote-tracking branch 'origin/develop' into calling_video_not_…

ceb5b02

…streamed # Conflicts: # kalium

ohassine added this pull request to the merge queue Mar 25, 2024

Merged via the queue into develop with commit 0758737 Mar 25, 2024
14 of 15 checks passed

ohassine deleted the calling_video_not_streamed branch March 25, 2024 10:14

ohassine added a commit that referenced this pull request Mar 25, 2024

fix: Calling video not streamed when enabling camera on preview scree…

1f4a71c

…n (WPB-7114) (#2801)

ohassine mentioned this pull request Mar 25, 2024

fix: Calling video not streamed when enabling camera on preview screen (WPB-7114) - cherrypick #2808

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Calling video not streamed when enabling camera on preview screen (WPB-7114) #2801

fix: Calling video not streamed when enabling camera on preview screen (WPB-7114) #2801

ohassine commented Mar 20, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 20, 2024

github-actions bot commented Mar 20, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024

AndroidBob commented Mar 20, 2024

AndroidBob commented Mar 20, 2024

AndroidBob commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

AndroidBob commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

codecov bot commented Mar 20, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024

AndroidBob commented Mar 20, 2024

MohamadJaara left a comment

github-actions bot commented Mar 25, 2024

AndroidBob commented Mar 25, 2024

fix: Calling video not streamed when enabling camera on preview screen (WPB-7114) #2801

fix: Calling video not streamed when enabling camera on preview screen (WPB-7114) #2801

Conversation

ohassine commented Mar 20, 2024 • edited by github-actions bot Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Causes (Optional)

Solutions

Testing

Test Coverage (Optional)

How to Test

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented Mar 20, 2024

github-actions bot commented Mar 20, 2024 • edited Loading

Test Results

github-actions bot commented Mar 20, 2024

AndroidBob commented Mar 20, 2024

AndroidBob commented Mar 20, 2024

AndroidBob commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

AndroidBob commented Mar 20, 2024

github-actions bot commented Mar 20, 2024

codecov bot commented Mar 20, 2024 • edited Loading

Codecov Report

github-actions bot commented Mar 20, 2024

AndroidBob commented Mar 20, 2024

MohamadJaara left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 25, 2024

AndroidBob commented Mar 25, 2024

ohassine commented Mar 20, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Mar 20, 2024 •

edited

Loading

codecov bot commented Mar 20, 2024 •

edited

Loading